Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tic tac toe game #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added tic tac toe game #37

wants to merge 2 commits into from

Conversation

Sumit6258
Copy link
Contributor

Added a mini game folder for games made using python

@gohil-jay gohil-jay self-requested a review October 22, 2021 05:51
gohil-jay
gohil-jay requested changes Oct 22, 2021
View reviewed changes
Copy link
Owner

@gohil-jay gohil-jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine, however, do change the sub-repo name to 'Tic Tac Toe' instead of 'Mini_Games' and python files as 'app.py' instead of 'Tic_Tac_toe.py'. Moreover, please attach a working GUI screenshot as well.

@Kavs-123
Copy link

Hey @gohil-jay , Pls assign this issue to me too, would like to work on the same

@gohil-jay
Copy link
Owner

Alright, sure @Kavs-123.

@Kavs-123
Copy link

Alright, sure @Kavs-123.

I have raised a pr #46 for the same...
Pls review it and merge it!
Thanks for assigning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gohil-jay gohil-jay gohil-jay requested changes

Assignees

@Sumit6258 Sumit6258

@Kavs-123 Kavs-123

Labels
Hacktoberfest hactoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sumit6258 @Kavs-123 @gohil-jay