Fix bad walk #6
Merged
Fix bad walk #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gohugoio#4 The main approach is to split the walk into two walks: 1. Insert the new nodes that would replace the original node, with care to avoid infinite loops, and mark the replaced nodes for deletion 2. Find the marked nodes and delete them.
bep
reviewed
Jan 24, 2024
|
Fine by me. |
|
@j2kun Done. Please update go.mod and run |
|
@j2kun I'll take a swing at Hugo documentation over the next couple of days, probably adding "math" page (title TBD) to the "Content management" section (https://gohugo.io/content-management). Need to cover config, JS inclusion methods, MathJax and KaTeX tradeoffs, examples, etc. After release, we can enable this on the docs site and include "live" examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4