Skip to content

Commit

Permalink
create: Correctly pass newContentEditor flags
Browse files Browse the repository at this point in the history
Fixes #9356
  • Loading branch information
jmooring authored and bep committed Jan 7, 2022
1 parent c8b5ab7 commit 0aca99f
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions create/content.go
Expand Up @@ -343,15 +343,24 @@ func (b *contentBuilder) openInEditorIfConfigured(filename string) error {
return nil
}

b.h.Log.Printf("Editing %q with %q ...\n", filename, editor)
cmd, err := b.h.Deps.ExecHelper.New(
editor,
editorExec := strings.Fields(editor)[0]
editorFlags := strings.Fields(editor)[1:]

var args []interface{}
for _, editorFlag := range editorFlags {
args = append(args, editorFlag)
}
args = append(
args,
filename,
hexec.WithStdin(os.Stdin),
hexec.WithStderr(os.Stderr),
hexec.WithStdout(os.Stdout),
)

b.h.Log.Printf("Editing %q with %q ...\n", filename, editorExec)

cmd, err := b.h.Deps.ExecHelper.New(editorExec, args...)
if err != nil {
return err
}
Expand Down

0 comments on commit 0aca99f

Please sign in to comment.