Skip to content

Commit

Permalink
server: Fix flaky TestServerPathEncodingIssues tests
Browse files Browse the repository at this point in the history
Set getNumHomes: 1 to enable 567 ms or 2 s of wait for the server
to be ready in TestServerPathEncodingIssues/Unicode_paths and
TestServerPathEncodingIssues/Windows_multilingual_404.

Fixes #10332
  • Loading branch information
anthonyfok authored and bep committed Oct 4, 2022
1 parent b002d47 commit 0addb30
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions commands/server_test.go
Expand Up @@ -25,7 +25,6 @@ import (

"github.com/gohugoio/hugo/config"
"github.com/gohugoio/hugo/helpers"
"github.com/gohugoio/hugo/htesting"
"golang.org/x/net/context"
"golang.org/x/sync/errgroup"

Expand Down Expand Up @@ -69,20 +68,14 @@ func TestServer404(t *testing.T) {
}

func TestServerPathEncodingIssues(t *testing.T) {
if htesting.IsGitHubAction() {
// This test is flaky on CI for some reason. Run it on Windows only for now.
// TODO(bep)
if runtime.GOOS != "windows" {
t.Skip("Skipping test on CI")
}
}
c := qt.New(t)

// Issue 10287
c.Run("Unicode paths", func(c *qt.C) {
r := runServerTest(c,
serverTestOptions{
pathsToGet: []string{"hügö/"},
pathsToGet: []string{"hügö/"},
getNumHomes: 1,
},
)

Expand Down Expand Up @@ -123,8 +116,9 @@ status = 404
`
r := runServerTest(c,
serverTestOptions{
config: config,
pathsToGet: []string{"en/this/does/not/exist", "es/this/does/not/exist"},
config: config,
pathsToGet: []string{"en/this/does/not/exist", "es/this/does/not/exist"},
getNumHomes: 1,
},
)

Expand Down

0 comments on commit 0addb30

Please sign in to comment.