Skip to content

Commit

Permalink
Add clock cli flag
Browse files Browse the repository at this point in the history
Close #8787
  • Loading branch information
satotake authored and bep committed May 8, 2022
1 parent f2946da commit e77ca3c
Show file tree
Hide file tree
Showing 26 changed files with 193 additions and 37 deletions.
3 changes: 2 additions & 1 deletion cache/filecache/filecache.go
Expand Up @@ -24,6 +24,7 @@ import (
"sync"
"time"

"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/common/hugio"

"github.com/gohugoio/hugo/helpers"
Expand Down Expand Up @@ -295,7 +296,7 @@ func (c *Cache) isExpired(modTime time.Time) bool {
if c.maxAge < 0 {
return false
}
return c.maxAge == 0 || time.Since(modTime) > c.maxAge
return c.maxAge == 0 || htime.Since(modTime) > c.maxAge
}

// For testing
Expand Down
23 changes: 23 additions & 0 deletions commands/commandeer.go
Expand Up @@ -15,6 +15,7 @@ package commands

import (
"errors"
"fmt"
"io/ioutil"
"net"
"os"
Expand All @@ -28,9 +29,11 @@ import (
"golang.org/x/sync/semaphore"

"github.com/gohugoio/hugo/common/herrors"
"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/common/hugo"
"github.com/gohugoio/hugo/common/paths"

"github.com/spf13/cast"
jww "github.com/spf13/jwalterweatherman"

"github.com/gohugoio/hugo/common/loggers"
Expand All @@ -41,6 +44,7 @@ import (
"github.com/gohugoio/hugo/hugolib"
"github.com/spf13/afero"

"github.com/bep/clock"
"github.com/bep/debounce"
"github.com/bep/overlayfs"
"github.com/gohugoio/hugo/common/types"
Expand Down Expand Up @@ -164,6 +168,20 @@ func (c *commandeer) initFs(fs *hugofs.Fs) error {
return nil
}

func (c *commandeer) initClock() error {
bt := c.Cfg.GetString("clock")
if bt == "" {
return nil
}

t, err := cast.StringToDateInDefaultLocation(bt, nil)
if err != nil {
return fmt.Errorf(`failed to parse "clock" flag: %s`, err)
}
htime.Clock = clock.Start(t)
return nil
}

func newCommandeer(mustHaveConfigFile, failOnInitErr, running bool, h *hugoBuilderCommon, f flagsToConfigHandler, cfgInit func(c *commandeer) error, subCmdVs ...*cobra.Command) (*commandeer, error) {
var rebuildDebouncer func(f func())
if running {
Expand Down Expand Up @@ -341,6 +359,11 @@ func (c *commandeer) loadConfig() error {

c.configFiles = configFiles

err = c.initClock()
if err != nil {
return err
}

if l, ok := c.Cfg.Get("languagesSorted").(langs.Languages); ok {
c.languagesConfigured = true
c.languages = l
Expand Down
7 changes: 5 additions & 2 deletions commands/commands.go
Expand Up @@ -18,6 +18,7 @@ import (
"os"
"time"

"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/common/hugo"
"github.com/gohugoio/hugo/common/loggers"
hpaths "github.com/gohugoio/hugo/common/paths"
Expand Down Expand Up @@ -151,7 +152,7 @@ built with love by spf13 and friends in Go.
Complete documentation is available at https://gohugo.io/.`,
RunE: func(cmd *cobra.Command, args []string) error {
defer cc.timeTrack(time.Now(), "Total")
defer cc.timeTrack(htime.Now(), "Total")
cfgInit := func(c *commandeer) error {
if cc.buildWatch {
c.Set("disableLiveReload", true)
Expand Down Expand Up @@ -210,6 +211,7 @@ type hugoBuilderCommon struct {

buildWatch bool
poll string
clock string

gc bool

Expand All @@ -236,7 +238,7 @@ func (cc *hugoBuilderCommon) timeTrack(start time.Time, name string) {
if cc.quiet {
return
}
elapsed := time.Since(start)
elapsed := htime.Since(start)
fmt.Printf("%s in %v ms\n", name, int(1000*elapsed.Seconds()))
}

Expand Down Expand Up @@ -279,6 +281,7 @@ func (cc *hugoBuilderCommon) handleCommonBuilderFlags(cmd *cobra.Command) {
cmd.PersistentFlags().StringVarP(&cc.environment, "environment", "e", "", "build environment")
cmd.PersistentFlags().StringP("themesDir", "", "", "filesystem path to themes directory")
cmd.PersistentFlags().StringP("ignoreVendorPaths", "", "", "ignores any _vendor for module paths matching the given Glob pattern")
cmd.PersistentFlags().StringVar(&cc.clock, "clock", "", "set clock inside hugo, e.g. --clock 2021-11-06T22:30:00.00+09:00")
}

func (cc *hugoBuilderCommon) handleFlags(cmd *cobra.Command) {
Expand Down
10 changes: 6 additions & 4 deletions commands/hugo.go
Expand Up @@ -33,6 +33,7 @@ import (
"github.com/gohugoio/hugo/hugofs/files"
"github.com/gohugoio/hugo/tpl"

"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/common/types"

"github.com/gohugoio/hugo/hugofs"
Expand Down Expand Up @@ -187,6 +188,7 @@ func initializeFlags(cmd *cobra.Command, cfg config.Provider) {
"buildDrafts",
"buildFuture",
"buildExpired",
"clock",
"uglyURLs",
"canonifyURLs",
"enableRobotsTXT",
Expand Down Expand Up @@ -679,7 +681,7 @@ func (c *commandeer) firstPathSpec() *helpers.PathSpec {
}

func (c *commandeer) timeTrack(start time.Time, name string) {
elapsed := time.Since(start)
elapsed := htime.Since(start)
c.logger.Printf("%s in %v ms", name, int(1000*elapsed.Seconds()))
}

Expand Down Expand Up @@ -790,7 +792,7 @@ func (c *commandeer) fullRebuild(changeType string) {
time.Sleep(2 * time.Second)
}()

defer c.timeTrack(time.Now(), "Rebuilt")
defer c.timeTrack(htime.Now(), "Rebuilt")

c.commandeerHugoState = newCommandeerHugoState()
err := c.loadConfig()
Expand Down Expand Up @@ -900,7 +902,7 @@ func (c *commandeer) printChangeDetected(typ string) {

c.logger.Println(msg)
const layout = "2006-01-02 15:04:05.000 -0700"
c.logger.Println(time.Now().Format(layout))
c.logger.Println(htime.Now().Format(layout))
}

const (
Expand Down Expand Up @@ -1135,7 +1137,7 @@ func (c *commandeer) handleEvents(watcher *watcher.Batcher,
c.changeDetector.PrepareNew()

func() {
defer c.timeTrack(time.Now(), "Total")
defer c.timeTrack(htime.Now(), "Total")
if err := c.rebuildSites(dynamicEvents); err != nil {
c.handleBuildErr(err, "Rebuild failed")
}
Expand Down
45 changes: 42 additions & 3 deletions commands/hugo_test.go
Expand Up @@ -29,7 +29,6 @@ import (

// Issue #5662
func TestHugoWithContentDirOverride(t *testing.T) {
t.Parallel()
c := qt.New(t)

files := `
Expand All @@ -51,7 +50,6 @@ Page: {{ .Title }}|

// Issue #9794
func TestHugoStaticFilesMultipleStaticAndManyFolders(t *testing.T) {
t.Parallel()
c := qt.New(t)

files := `
Expand Down Expand Up @@ -95,13 +93,44 @@ Home.

}

// Issue #8787
func TestHugoListCommandsWithClockFlag(t *testing.T) {
c := qt.New(t)

files := `
-- config.toml --
baseURL = "https://example.org"
title = "Hugo Commands"
-- content/past.md --
---
title: "Past"
date: 2000-11-06
---
-- content/future.md --
---
title: "Future"
date: 2200-11-06
---
-- layouts/_default/single.html --
Page: {{ .Title }}|
`
s := newTestHugoCmdBuilder(c, files, []string{"list", "future"}).Build()
p := filepath.Join("content", "future.md")
s.AssertStdout(p + ",2200-11-06T00:00:00Z")

s = newTestHugoCmdBuilder(c, files, []string{"list", "future", "--clock", "2300-11-06"}).Build()
s.AssertStdout("")
}

type testHugoCmdBuilder struct {
*qt.C

fs afero.Fs
dir string
files string
args []string
out string
}

func newTestHugoCmdBuilder(c *qt.C, files string, args []string) *testHugoCmdBuilder {
Expand All @@ -127,8 +156,12 @@ func (s *testHugoCmdBuilder) Build() *testHugoCmdBuilder {
args := append(s.args, "-s="+s.dir, "--quiet")
cmd.SetArgs(args)

_, err := cmd.ExecuteC()
out, err := captureStdout(func() error {
_, err := cmd.ExecuteC()
return err
})
s.Assert(err, qt.IsNil)
s.out = out

return s
}
Expand All @@ -149,3 +182,9 @@ func (s *testHugoCmdBuilder) AssertFileContent(filename string, matches ...strin
}
}
}

func (s *testHugoCmdBuilder) AssertStdout(match string) {
s.Helper()
content := strings.TrimSpace(s.out)
s.Assert(content, qt.Contains, strings.TrimSpace(match))
}
5 changes: 3 additions & 2 deletions commands/import_jekyll.go
Expand Up @@ -28,6 +28,7 @@ import (

"github.com/gohugoio/hugo/parser/pageparser"

"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/common/hugio"

"github.com/gohugoio/hugo/parser/metadecoders"
Expand Down Expand Up @@ -362,12 +363,12 @@ func parseJekyllFilename(filename string) (time.Time, string, error) {
re := regexp.MustCompile(`(\d+-\d+-\d+)-(.+)\..*`)
r := re.FindAllStringSubmatch(filename, -1)
if len(r) == 0 {
return time.Now(), "", errors.New("filename not match")
return htime.Now(), "", errors.New("filename not match")
}

postDate, err := time.Parse("2006-1-2", r[0][1])
if err != nil {
return time.Now(), "", err
return htime.Now(), "", err
}

postName := r[0][2]
Expand Down
8 changes: 8 additions & 0 deletions commands/list.go
Expand Up @@ -99,6 +99,10 @@ List requires a subcommand, e.g. ` + "`hugo list drafts`.",
return newSystemError("Error building sites", err)
}

if err != nil {
return newSystemError("Error building sites", err)
}

writer := csv.NewWriter(os.Stdout)
defer writer.Flush()

Expand Down Expand Up @@ -127,6 +131,10 @@ List requires a subcommand, e.g. ` + "`hugo list drafts`.",
return newSystemError("Error building sites", err)
}

if err != nil {
return newSystemError("Error building sites", err)
}

writer := csv.NewWriter(os.Stdout)
defer writer.Flush()

Expand Down
4 changes: 2 additions & 2 deletions commands/list_test.go
Expand Up @@ -34,9 +34,9 @@ func TestListAll(t *testing.T) {
hugoCmd := newCommandsBuilder().addAll().build()
cmd := hugoCmd.getCommand()

defer func() {
t.Cleanup(func() {
os.RemoveAll(dir)
}()
})

cmd.SetArgs([]string{"-s=" + dir, "list", "all"})

Expand Down
4 changes: 2 additions & 2 deletions commands/new_theme.go
Expand Up @@ -18,8 +18,8 @@ import (
"errors"
"path/filepath"
"strings"
"time"

"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/helpers"
"github.com/gohugoio/hugo/hugofs"
"github.com/spf13/cobra"
Expand Down Expand Up @@ -113,7 +113,7 @@ func (n *newThemeCmd) newTheme(cmd *cobra.Command, args []string) error {

by := []byte(`The MIT License (MIT)
Copyright (c) ` + time.Now().Format("2006") + ` YOUR_NAME_HERE
Copyright (c) ` + htime.Now().Format("2006") + ` YOUR_NAME_HERE
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
Expand Down
7 changes: 4 additions & 3 deletions commands/server.go
Expand Up @@ -33,6 +33,7 @@ import (
"syscall"
"time"

"github.com/gohugoio/hugo/common/htime"
"github.com/gohugoio/hugo/common/paths"
"golang.org/x/sync/errgroup"

Expand Down Expand Up @@ -255,7 +256,7 @@ func (sc *serverCmd) server(cmd *cobra.Command, args []string) error {
}

err = func() error {
defer c.timeTrack(time.Now(), "Built")
defer c.timeTrack(htime.Now(), "Built")
err := c.serverBuild()
if err != nil {
cmd.PrintErrln("Error:", err.Error())
Expand Down Expand Up @@ -668,13 +669,13 @@ func memStats() error {
go func() {
var stats runtime.MemStats

start := time.Now().UnixNano()
start := htime.Now().UnixNano()

for {
runtime.ReadMemStats(&stats)
if fileMemStats != nil {
fileMemStats.WriteString(fmt.Sprintf("%d\t%d\t%d\t%d\t%d\n",
(time.Now().UnixNano()-start)/1000000, stats.HeapSys, stats.HeapAlloc, stats.HeapIdle, stats.HeapReleased))
(htime.Now().UnixNano()-start)/1000000, stats.HeapSys, stats.HeapAlloc, stats.HeapIdle, stats.HeapReleased))
time.Sleep(interval)
} else {
break
Expand Down
12 changes: 12 additions & 0 deletions common/htime/time.go
Expand Up @@ -17,6 +17,7 @@ import (
"strings"
"time"

"github.com/bep/clock"
"github.com/spf13/cast"

toml "github.com/pelletier/go-toml/v2"
Expand Down Expand Up @@ -74,6 +75,7 @@ var (
"November",
"December",
}
Clock = clock.Start(time.Now())
)

func NewTimeFormatter(ltr locales.Translator) TimeFormatter {
Expand Down Expand Up @@ -148,3 +150,13 @@ func ToTimeInDefaultLocationE(i any, location *time.Location) (tim time.Time, er
}
return cast.ToTimeInDefaultLocationE(i, location)
}

// Now returns time.Now() or time value based on`clock` flag.
// Use this function to fake time inside hugo.
func Now() time.Time {
return Clock.Now()
}

func Since(t time.Time) time.Duration {
return Clock.Now().Sub(t)
}

0 comments on commit e77ca3c

Please sign in to comment.