feat: add parents property on page #10567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that the idea is good, but I suggest we use Also, could you:
|
bep
reviewed
Dec 22, 2022
hugolib/page__tree.go
Outdated
| func (pt pageTree) Ancestors() (parents page.Pages) { | ||
| parent := pt.Parent() | ||
| for parent != nil { | ||
| parents = append(parents, parent) |
There was a problem hiding this comment.
Nitpicking, but
parentsshould be named something else- we only use named return values when really needed (e.g. when we need to capture a panic and assign to err), so I would prefer
Ancestors() page.Pages
There was a problem hiding this comment.
OK, I can do it. I need to merge this soonish, as I'm releasing today.
There was a problem hiding this comment.
Sorry, I got COVID-19 and I'm fine now
|
@jmooring for me this is an obvious improvement, agree? |
Yes. Took it for a spin. 👍 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parents property on page, simplify breadcrumb navigation implementation complexity
community tricks see: https://discourse.gohugo.io/search?q=breadcrumb
in HTML:
{{- $page := . -} <nav class="breadcrumb"> <ul> {{- range .Parents.Reverse }} <li><a href="{{ .Permalink }}">{{ .LinkTitle }}</a></li> {{- end }} <li class="active">{{ .LinkTitle }}</li> </ul> </nav>in JSON-LD:
see https://developers.google.com/search/docs/appearance/structured-data/breadcrumb
{{- $breadcrumbItems := slice -}} {{- range $index, $page := append .Parents.Reverse . -}} {{- $item := dict "@type" "ListItem" "position" (add $index 1) "name" $page.Title "item" $page.Permalink -}} {{- $breadcrumbItems = append $breadcrumbItems $item -}} {{- end -}} <script type="application/ld+json"> {{- dict "@context" "https://schema.org" "@type" "BreadcrumbList" "itemListElement" $breadcrumbItems -}} </script>