Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have some way of telling whether a page is RTL or LTR #3255

Closed
rayjolt opened this issue Apr 1, 2017 · 2 comments
Closed

Have some way of telling whether a page is RTL or LTR #3255

rayjolt opened this issue Apr 1, 2017 · 2 comments

Comments

@rayjolt
Copy link
Contributor

rayjolt commented Apr 1, 2017

When implementing multilingual themes, it would be useful to know the direction of the script the current page uses. For example, in the header.html template in the "hugo-zen-theme-rtl" theme, the following code is used to load styles for right-to-left scripts:

{{ if eq .Lang "ar" }}<link rel="stylesheet" href="/css/rtl.css">{{ end }}

If you want to test for more languages than just Arabic, this quickly becomes unwieldy. Instead, it would be nice to have Hugo define a page variable or similar so that you could do something like this:

{{ if eq .TextDirection "rtl" }}<link rel="stylesheet" href="/css/rtl.css">{{ end }}

You can already do something like this by setting a custom parameter for each language in your config.toml, but it would be better for the process to be automatic. And even if the process can't be automatic, it would be a good idea to have one established way of detecting text direction, so that if people switch themes RTL support will work without any adjustments to settings.

@stale
Copy link

stale bot commented Dec 6, 2017

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants