Support open "current content page" in browser #3645

bep · 2017-06-25T18:27:46Z

This is pretty cool.

anthonyfok · 2017-06-26T11:15:06Z

commands/hugo.go

+
+						if navigate {
+
+							// It is probably more confusing than usueful


Please fix minor typo: usueful → useful

anthonyfok · 2017-06-26T19:23:32Z

This is pretty cool.

This is really, really awesome! Totally love this new feature! Thank you Bjørn!

One minor detail that did get me confused though: the demo at https://twitter.com/GoHugoIO/status/879065641315119104, it Hugo not only get the web browser jumps to the current page, but it almost seems like it jumps to the current section! (No, wait, I am just imagining things... Hoho!)

anthonyfok

My Go coding skill is still at an novice level (I am serious, and not being humble), but at a quick glance, your code looks good, and it works in Google Chrome on Debian GNU/Linux, so yes, I think it is awesome!

bep · 2017-06-26T19:31:11Z

but it almost seems like it jumps to the current section! (No, wait, I am just imagining things... Hoho!)

That would be magic!

But I agree, this is a feature that I really want myself, and is golden for site-wide edits (copy-edits etc.).

Thanks for testing it! I need some Windows user to take it for a spin, but I will ask in the forum.

digitalcraftsman · 2017-06-26T19:39:10Z

commands/server.go

@@ -87,6 +88,7 @@ func init() {
 	serverCmd.Flags().BoolVarP(&serverWatch, "watch", "w", true, "watch filesystem for changes and recreate as needed")
 	serverCmd.Flags().BoolVarP(&serverAppend, "appendPort", "", true, "append port to baseURL")
 	serverCmd.Flags().BoolVar(&disableLiveReload, "disableLiveReload", false, "watch without enabling live browser reload on rebuild")
+	serverCmd.Flags().BoolVar(&navigateToChanged, "navigateToChanged", false, "navigate to changed content file on live browser reload")


What about "navigate to changed content file in browser on live reload" instead?

digitalcraftsman · 2017-06-26T19:42:37Z

This feature is really nice and might have been a timer saver for @rdwatters during the rewrite of the docs 😉 .

Thanks for testing it! I need some Windows user to take it for a spin, but I will ask in the forum.

I tried it too and it worked perfectly. But I'm on Linux as well.

anthonyfok · 2017-06-26T19:44:43Z

I need some Windows user to take it for a spin, but I will ask in the forum.

I could reboot into Windows 10 and do some testing there too. Hope I can post my result within half an hour? :-)

bep · 2017-06-26T19:48:06Z

There is no rush with the testing, I assume it "just works" and it is some time before we release this to the public. This should work, the only gotcha would be path issues on Windows.

I'm on macOs, and that works fine, too, of course (in Chrome and Safari).

anthonyfok · 2017-06-26T21:08:22Z

Preliminary result under Windows 10:

Using Notepad as the editor, it works with both Internet Explorer 11, Microsoft Edge, and Google Chrome. Hurray!

Source changed "C:\\Users\\Anthony\\go\\src\\github.com\\gohugoio\\hugo\\docs\\content\\release-notes\\release-notes.md": WRITE
INFO 2017/06/26 15:00:11 rereading C:\Users\Anthony\go\src\github.com\gohugoio\hugo\docs\content\release-notes\release-notes.md

filename = C:\Users\Anthony\go\src\github.com\gohugoio\hugo\docs\content\release-notes\release-notes.md
GetContentPage(): rel = release-notes\release-notes.md
GetContentPage(): pos = 114

Using Vim (from Git Bash, MINGW64) as the editor: No go... for some unknown reason, it generates a WRITE event on the directory instead of the file:

Source changed "C:\\Users\\Anthony\\go\\src\\github.com\\gohugoio\\hugo\\docs\\content\\release-notes": WRITE
Source changed "C:\\Users\\Anthony\\go\\src\\github.com\\gohugoio\\hugo\\docs\\content\\release-notes\\release-notes.md": RENAME
Source changed "C:\\Users\\Anthony\\go\\src\\github.com\\gohugoio\\hugo\\docs\\content\\release-notes\\release-notes.md": CREATE
Source changed "C:\\Users\\Anthony\\go\\src\\github.com\\gohugoio\\hugo\\docs\\content\\release-notes\\release-notes.md": WRITE
INFO 2017/06/26 15:04:58 rereading C:\Users\Anthony\go\src\github.com\gohugoio\hugo\docs\content\release-notes\release-notes.md
INFO 2017/06/26 15:04:58 rereading C:\Users\Anthony\go\src\github.com\gohugoio\hugo\docs\content\release-notes\release-notes.md
INFO 2017/06/26 15:04:58 rereading C:\Users\Anthony\go\src\github.com\gohugoio\hugo\docs\content\release-notes\release-notes.md

filename = C:\Users\Anthony\go\src\github.com\gohugoio\hugo\docs\content\release-notes
GetContentPage(): rel = release-notes
GetContentPage(): pos = -1

bep · 2017-06-26T21:12:02Z

Using Vim (from Git Bash, MINGW64) as the editor: No go... for some unknown reason, it generates a WRITE event on the directory instead of the file:

But it ALSO generates one for the file. So, I should adjust my logic to pick the first file WRITE event. I will create a new PR with a fix tomorrow. Thanks for the testing.

anthonyfok · 2017-06-26T21:16:19Z

But it ALSO generates one for the file. So, I should adjust my logic to pick the first file WRITE event. I will create a new PR with a fix tomorrow. Thanks for the testing.

You're very welcome! Yes, I am looking at pickOneWritePath() now too, and was wondering about the same. :-) I will create a PR too as an exercise for myself, but if it turns out to be an inefficient or incorrect way of doing it, please feel free to ignore my PR (if I ever get it done, haha).

Have a good night!

bep · 2017-06-26T21:17:46Z

) I will create a PR too as an exercise for myself

Yea, that would be better -- so you could test it yourself. You can check if it is a file, but the easiest is maybe to pick the "longest WRITE event". We really should get some automatic server tests running, but that will have to wait for another day.

@bep

This ensures the new "open 'current content page' in browser" works on Windows, especially with Emacs and Vim. Special thanks to @bep for coming up with the idea of the fix. See gohugoio#3645

@bep

This ensures the new "open 'current content page' in browser" works on Windows, especially with Emacs and Vim. Special thanks to @bep for coming up with the idea of the fix. See #3645

github-actions · 2022-02-11T01:52:35Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

bep force-pushed the liveo branch 4 times, most recently from bd43d57 to 6efa7b1 Compare June 25, 2017 18:53

Support open "current content page" in browser

29e035a

Fixes gohugoio#3643

bep force-pushed the liveo branch from 6efa7b1 to 29e035a Compare June 25, 2017 18:58

bep added the InProgress label Jun 25, 2017

bep added 4 commits June 26, 2017 09:44

Navigate on WRITE only

f23d0ea

Add navigateToChanged flag/config

8a741f0

Add test for GetContentPage

59a9c9a

Polish

ab5d6d9

bep changed the title ~~WIP Support open "current content page" in browser~~ Support open "current content page" in browser Jun 26, 2017

bep added NeedsTriage and removed InProgress labels Jun 26, 2017

bep requested review from anthonyfok and digitalcraftsman June 26, 2017 08:25

bep mentioned this pull request Jun 26, 2017

Document navigateToChanged gohugoio/hugoDocs#21

Closed

anthonyfok reviewed Jun 26, 2017

View reviewed changes

bep and others added 2 commits June 26, 2017 14:58

Spelling

e45e9a2

Remove trailing whitespace in JavaScript snippet

7efd718

anthonyfok approved these changes Jun 26, 2017

View reviewed changes

bep merged commit c825a73 into gohugoio:master Jun 26, 2017

digitalcraftsman reviewed Jun 26, 2017

View reviewed changes

anthonyfok mentioned this pull request Jun 27, 2017

Make --navigateToChanged more robust on Windows #3652

Merged

github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support open "current content page" in browser #3645

Support open "current content page" in browser #3645

bep commented Jun 25, 2017

anthonyfok Jun 26, 2017

anthonyfok commented Jun 26, 2017

anthonyfok left a comment •

edited

Loading

bep commented Jun 26, 2017

digitalcraftsman Jun 26, 2017

digitalcraftsman commented Jun 26, 2017 •

edited

Loading

anthonyfok commented Jun 26, 2017

bep commented Jun 26, 2017 •

edited

Loading

anthonyfok commented Jun 26, 2017

bep commented Jun 26, 2017 •

edited

Loading

anthonyfok commented Jun 26, 2017

bep commented Jun 26, 2017 •

edited

Loading

github-actions bot commented Feb 11, 2022

Support open "current content page" in browser #3645

Support open "current content page" in browser #3645

Conversation

bep commented Jun 25, 2017

anthonyfok Jun 26, 2017

Choose a reason for hiding this comment

anthonyfok commented Jun 26, 2017

anthonyfok left a comment • edited Loading

Choose a reason for hiding this comment

bep commented Jun 26, 2017

digitalcraftsman Jun 26, 2017

Choose a reason for hiding this comment

digitalcraftsman commented Jun 26, 2017 • edited Loading

anthonyfok commented Jun 26, 2017

bep commented Jun 26, 2017 • edited Loading

anthonyfok commented Jun 26, 2017

bep commented Jun 26, 2017 • edited Loading

anthonyfok commented Jun 26, 2017

bep commented Jun 26, 2017 • edited Loading

github-actions bot commented Feb 11, 2022

anthonyfok left a comment •

edited

Loading

digitalcraftsman commented Jun 26, 2017 •

edited

Loading

bep commented Jun 26, 2017 •

edited

Loading

bep commented Jun 26, 2017 •

edited

Loading

bep commented Jun 26, 2017 •

edited

Loading