helpers: Add --trace to asciidoctor args

[miltador]

This will help to understand and fix errors by seeing stacktrace of an error.

[bep]

I'm by no means an expert here, but we do fallback to asciidoc if asciidoctor isn't available -- and I don't see that flag there.

[miltador]

I think asciidoc will just ignore it. Or I can add a check to only add --trace for asciidoctor.

[anthonyfok]

Hi @miltador,

I think asciidoc will just ignore it.

$ asciidoc --version
asciidoc 8.6.9
$ asciidoc --trace
asciidoc: illegal command options
$ echo $?
1

So asciidoc does complain about an unknown command-line option and does exit with an error.

Or I can add a check to only add --trace for asciidoctor.

Please do so. 👍 Thank you for your contribution! 😉

[miltador]

Thanks for a test! Added a check.

Will add a smarter check (WIP).

[miltador]

Added smarter check for asciidoctor.
@anthonyfok it is ready for review now.

[anthonyfok]

Thank you @miltador!

One tiny problem though: If both AsciiDoc and Asciidoctor are installed, your code would choose AsciiDoc over Asciidoctor. I am pretty sure that is not what you intended, especially since you use Ascidoctor yourself, and also because previous Hugo code has always "favoured" Asciidoctor over AsciiDoc. :-)

Could you please take a look again? Many thanks!

[miltador]

@anthonyfok, switched the order to first check for Asciidoctor and then for Asciidoc.

[anthonyfok]

That was very quick! Thank you @miltador!
Looks good to me! :-)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.