Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserveTaxonomyNames FALSE not changing single Polish characters ( Ł ł ) #7542

Closed
idarek opened this issue Aug 9, 2020 · 10 comments
Closed
Labels

Comments

@idarek
Copy link

idarek commented Aug 9, 2020

$ hugo version 0.74.3

I have converted my blog to Hugo and trying to match old links with new one.
Hugo by default generating tags with accented characters as I see. As I don't want that, I added preserveTaxonomyNames in FALSE state to config and in most cases its sorted, but not all characters are changed.

This is not working for Polish language
ł > l

@idarek idarek changed the title preserveTaxonomyNames FALSE not changing all Polish character ( Ł ł ) preserveTaxonomyNames FALSE not changing all Polish characters ( Ł ł ) Aug 9, 2020
@idarek
Copy link
Author

idarek commented Sep 14, 2020

@bep could you advise, are fix for this been implemented in 0.75 released now?

@davidsneighbour
Copy link
Contributor

davidsneighbour commented Sep 30, 2020

According to https://discourse.gohugo.io/t/what-part-of-hugo-is-responsible-for-changing-characters/28578 it's only one single character that is not transformed. All other Polish special characters are transformed.

@idarek idarek changed the title preserveTaxonomyNames FALSE not changing all Polish characters ( Ł ł ) preserveTaxonomyNames FALSE not changing single Polish characters ( Ł ł ) Oct 24, 2020
@moorereason
Copy link
Contributor

I don't pretend to understand Unicode normalization and transformation, but here are some clues.

I believe the transformation is happening here, by way of UnicodeSanitize.

We're doing Unicode normalization and removing the Mn category of Unicode characters. While playing around with the logic, I discovered that ł falls into the Ll category of lowercase letters.

@idarek
Copy link
Author

idarek commented Oct 24, 2020

Yes, its fall (shall be changed to) Ll and been surprised that all other characters (ąśćźżęóń) are converted correctly but not this one single character. Any chance to implement a fix for that somehow?

@idarek
Copy link
Author

idarek commented Apr 21, 2021

Hi, Just want to bump and ask if there is any progress with fixing issue with this single character in polish that shall be converted from "ł" to "l"

I think ł is not changed, because is incorrectly interpreted as equivalent of £ pound symbol Ł or other currency that use that but may be wrong

@Wirone
Copy link

Wirone commented Apr 15, 2022

Problem remains on Hugo v0.96, ł and Ł are the only polish letters that are not converted in slugs.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Apr 16, 2023
@idarek
Copy link
Author

idarek commented Apr 16, 2023

The problem remains on Hugo v0.111.3, ł and Ł are the only Polish letters that are not converted in slugs due to confusion of this symbol with the pound sterling symbol £ (U+00A3).

@github-actions github-actions bot removed the Stale label Apr 17, 2023
@jmooring
Copy link
Member

The preserveTaxonomyNames configuration option was removed in v0.55.0. The desired functionality is proposed in #9134.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants