Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This example project should not require unsafe settings #57

Closed
bep opened this issue Nov 23, 2019 · 6 comments
Closed

This example project should not require unsafe settings #57

bep opened this issue Nov 23, 2019 · 6 comments
Assignees

Comments

@bep
Copy link
Member

bep commented Nov 23, 2019

A little reminder re. the discussions about Goldmark.

This example should run fine with:

  • Unsafe = false
  • Inline shortcodes turned off

This project is supposed to be basic.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Nov 23, 2019

I have just sent #58 to address your concerns above.

The biggest change is the removal of the sample post for Math Typesetting with KaTex since it is impossible to showcase it without Inline Shorcodes.

Unless you decide to enable: https://github.com/litao91/goldmark-mathjax

If you are OK then feel free to merge the PR.

I have closed #58 we will not be dropping Math Typesetting support on the Hugo Themes Showcase for now. The themes showcase will be using Blackfriday until gohugoio/hugo#6544 is resolved.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented May 22, 2020

Actually I have just discovered that Blackfriday is no longer needed to display Math Typesetting in Hugo Theme demos (better late than never I suppose).

So really there is no critical need about adding Goldmark Math Extensions (would be nice) as things work as they are set up right now.

@bep I have just removed the mmark content file from this repo in c4afa25

Also the themeSite was upgraded to use Goldmark instead of Blackfriday in gohugoio/hugoThemesSite@854653f

Hope that you realize that the Goldmark unsafe flag and the Inline Shorcodes are needed to display the various Hugo features in the theme demos of the Hugo Themes Showcase.

If you are OK with the above, then perhaps this issue should be closed.

@onedrawingperday
Copy link
Contributor

The latest Hugo Themes deploy was a success with the latest changes.

So now the Hugo Themes website no longer needs mmark or Blackfriday.

All sample content files (including the one for Math Typesetting with KaTeX) render fine with Goldmark.

@sephore
Copy link

sephore commented May 27, 2020

Is it just me, or the Math Typesetting example with Goldmark isn't making a distinction between inline and block?

@onedrawingperday
Copy link
Contributor

@sephore
Your question is out of place in this issue.

If you want to discuss your question then open a new issue and also make sure to provide a proper description of what you are referring to.

@skyfaller
Copy link

skyfaller commented Jun 5, 2021

Hi folks, I just want to point out that <cite> is stripped out with safe settings. The <cite> tag appears in https://github.com/gohugoio/hugoBasicExample/blob/master/content/post/markdown-syntax.md#blockquote-with-attribution :

#### Blockquote with attribution

> Don't communicate by sharing memory, share memory by communicating.<br>
> — <cite>Rob Pike[^1]</cite>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants