Improving function signatures (#98) #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Thanks for this. I will merge once you've made the suggested changes. At some point in the coming months, the function section of the documentation will become data driven, so please don't spend any more time adding signatures. I've added them in the past, but at this point the effort of writing (and reviewing!) isn't worth the return.
deining
added a commit
to deining/hugoDocs-ad
that referenced
this pull request
Nov 23, 2022
jmooring
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the signature of various functions.
Closes #98.