Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

New theme: Tikva #501

Closed
9 tasks done
geschke opened this issue Nov 16, 2018 · 4 comments
Closed
9 tasks done

New theme: Tikva #501

geschke opened this issue Nov 16, 2018 · 4 comments

Comments

@geschke
Copy link

geschke commented Nov 16, 2018

Theme submission

Here's my submission of a theme named "Tikva". It is a port of my Grav and WordPress theme with additions from my currently unpublished WordPress theme named "Azbalac".

Link to my theme repository: https://github.com/geschke/hugo-tikva

I made sure that...

  • an open source license has been added to LICENSE.md

  • the repository contains a good README.md describing my theme

  • all metadata have been added to theme.toml

  • screenshots have been added in the images/ folder with the required dimensions

  • in case I'm using a customized demo via the exampleSite folder that

    • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
    • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  • I tested my theme against the gohugoio/HugoBasicExample

    • I've checked the developer tools' console in my browser for error messages

I tested with the HugoBasicExample and with the GoHugo site build and my demo seemed to work as intended:

==== PROCESSING  hugo-tikva  ======
Building site for theme hugo-tikva using its own exampleSite to ../themeSite/static/theme/hugo-tikva/
Finished with 0 errors ...

Let me know if I'm missing anything.

Thanks in advance!
Kind regards,
Ralf

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Nov 20, 2018

Hello @geschke and thank you for sharing your theme.

Everything is looking good on my end when I execute the Build Script. 👍

However the licencelink in your theme.toml throws a 404

Please fix this. Thanks.

@geschke
Copy link
Author

geschke commented Nov 21, 2018

Hello @onedrawingperday - thanks for your feedback!
I've fixed the URL to the license file in theme.toml and and issue with displaying meta data on single pages.

Hope that's everything ok now. :-)

Kind regards,
Ralf

@onedrawingperday
Copy link
Contributor

@geschke Thanks for the fixes. 👍

@digitalcraftsman This theme is ready to be added to the website.

@digitalcraftsman
Copy link
Member

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants