-
-
Notifications
You must be signed in to change notification settings - Fork 244
Theme Demos with third party tracking #535
Comments
I don't have any issue removing the code, just wondering if this is documented somewhere for future theme authors? |
We don’t see this issue often in theme submissions (and if we do we make sure tracking is disabled) but I will send a Pull Request to add a note in the repository’s README later today. Thanks for the hint. |
…nt etc See #535 (comment) for the need to add the note about 3rd party tracking. See zhaohuabing/hugo-theme-cleanwhite#25 for the need to emphasize the note about neutral content. Also I consolidated the Notes of the *Adding a theme to the list* section under a single sub-heading and inserted bullet points. See #537
There are also themes that have enabled the default Share Plugins by various Social Media platforms -that track users- so far I have found the following:
NOTE I will publish a Theme Component that theme authors can use as a guide in their themes. I will start opening issues to notify theme authors about the tracking in their themes' demos after I publish the sharing buttons theme component. Again there will be the same 30 day grace period, for theme authors to respond with a fix after notification, beyond that time frame I will be sending a few Pull Requests to have these demos disabled, until their authors remove the tracking. |
@onedrawingperday Could you point out which portion of my code I need to modify? I still don't understand much of this issue. A short explanation would be helpful. Thanks for notifying me on the forum. |
I had a better look and the code in your theme does not use the JS provided by the various social media platforms. There is an inline JS script for the pop-up preview and no tracking. So feel free to enable the sharing partial in your theme. And sorry for the false alarm.
This issue is about themes that have enabled third party services in their demos such as:
The JS files provided by these platforms track page visitors and send the data to these third party services. This type of tracking requires opt-in for visitors from the European Union. Since these demos appear on the Hugo website these services should not be enabled. We do not have the means to know which Example Sites require an opt-in mechanism and which don't, since authors update their themes after they are accepted in this repo. Also we have an open issue about creating an opt-in banner across the Hugo websites for the Hugo project's Google Analytics' report. |
This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help. |
Closing this issue because a large part of it is resolved. The remaining part moved to #564 |
The following themes have third party tracking (Google Analytics, Disqus) in their demos:
In the coming days I will be opening issues to notify theme authors about the need to remove the third party tracking from their themes' Example Sites.
There will be a 30 day grace period so that authors can respond with a fix. Beyond this time frame, I will be sending Pull Requests to have these demos disabled in the Themes Site Build Script, until the tracking is removed.
The text was updated successfully, but these errors were encountered: