Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

New Theme: Hugo Scroll #881

Closed
10 tasks done
janraasch opened this issue Jul 7, 2020 · 11 comments
Closed
10 tasks done

New Theme: Hugo Scroll #881

janraasch opened this issue Jul 7, 2020 · 11 comments

Comments

@janraasch
Copy link

janraasch commented Jul 7, 2020

Hi there πŸ™‹πŸΌβ€β™‚οΈπŸ˜

Theme submission

Link to my theme repository: https://github.com/janraasch/hugo-scroll

I made sure that...

  • the repository contains a good README.md describing my theme
  • an open source license has been added to LICENSE.md
  • all metadata have been added to theme.toml
  • screenshots have been added in the images/ folder with the required dimensions
  • in case I'm using a customized demo via the exampleSite folder that
  • I tested my theme against the gohugoio/HugoBasicExample
    • I've checked the developer tools' console in my browser for error messages
  • in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

I don't have a Twitter-account, but I sure would not mind a mention of my website https://www.janraasch.com on Twitter :-).


Please let me know, if you need anything else from my side.

Thank you β™₯️ and keep up the great work πŸ‘‹.

@stale
Copy link

stale bot commented Jul 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Jul 27, 2020
@janraasch
Copy link
Author

janraasch commented Jul 27, 2020

Hi stale (bot), please be patient :-). Let's at least wait for one of the maintainers to reply here.

@stale stale bot removed the Stale label Jul 27, 2020
@digitalcraftsman
Copy link
Member

Hi Jan,

excuse the delay. I was busy with the preperation of an exam that I wrote today. I plan to review the theme submissions in the upcoming days.

@janraasch
Copy link
Author

janraasch commented Jul 27, 2020 via email

@digitalcraftsman
Copy link
Member

Hello again,

first of all, thanks for sharing your theme with the Hugo community. During the review the only issue I noticed was that the header image on the very top of your theme isn't when running the build script for www.themes.gohugo.io.

While your demo is hosted at http://localhost:1313/theme/hugo-scroll/ the image links due to relURL to /images/cover-image.jpg. Thus the image's path is relative to the root of the domain (http://localhost:1313/), not to http://localhost:1313/theme/hugo-scroll/. By not using relURL you keep the path as images/cover-image.jpg, which works fine as for the images in the sections below.

@janraasch
Copy link
Author

Hi there @digitalcraftsman πŸ‘‹πŸ», thank you for taking the time to review this.

During the review the only issue I noticed was that the header image on the very top of your theme isn't when running the build script for www.themes.gohugo.io.

Nice catch πŸ‘ . I removed the usage of relURL via zjedi/hugo-scroll@0fe91fc.

Please try again.

Kind regards and have a nice weekend,
Jan

digitalcraftsman added a commit that referenced this issue Aug 1, 2020
@digitalcraftsman
Copy link
Member

Thanks for applying the fix. Your theme is already live on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

Kind regards and have a nice weekend,

Likewise Jan

@janraasch
Copy link
Author

Awesome, @digitalcraftsman. Thank you very much ❀️ πŸ‘. I am proud to be a part of the Hugo community 😊.

I'm looking forward to the announcement on Twitter https://twitter.com/gohugoio πŸ‘€ 🍭.

Have a good start into the Β»workΒ«-week πŸ˜› πŸ˜‡.

@digitalcraftsman
Copy link
Member

Awesome, @digitalcraftsman. Thank you very much ❀️ πŸ‘. I am proud to be a part of the Hugo community 😊.

Thanks for giving something back πŸ˜‰

I'm looking forward to the announcement on Twitter twitter.com/gohugoio πŸ‘€ 🍭.

tl;dr: for an unknown reason my Twitter account (not @ gohugoio) has been suspended by inadvertently trigger some filter or something alike. Thus, I'm currently not able to post anything through (@ gohugoio). I've contacted Twitter's support to resolve the issue. I'll reopen this issue as a reminder for the announcement.

Have a good start into the Β»workΒ«-week πŸ˜› πŸ˜‡.

You as well and happy Hugoing.

@digitalcraftsman
Copy link
Member

Your theme has now been promoted on Hugo's official Twitter account as well (see https://twitter.com/GoHugoIO/status/1301896092574011394).

@janraasch
Copy link
Author

That's great. Thank you very much, @digitalcraftsman πŸ‘.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants