Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Pagination option names deviate from query param names #5

Closed
jeffandersen opened this issue Nov 10, 2013 · 1 comment · Fixed by #6
Closed

Pagination option names deviate from query param names #5

jeffandersen opened this issue Nov 10, 2013 · 1 comment · Fixed by #6
Labels
bug

Comments

@jeffandersen
Copy link
Contributor

The client should take options matching the actual request going out:

https://developers.goinstant.com/v1/rest-api/index.html#query-parameters
@stash
Copy link
Contributor

stash commented Nov 10, 2013

Right now, in the code, we've got pageNumber, etc. defined. The server ignores them since it expects page_number=N, not pageNumber=N

ianlivingstone added a commit that referenced this issue Nov 12, 2013
@ianlivingstone
Merge pull request #5 from goinstant/jeffandersen/no-creds
4bf8a4b 
Allow client to be instantiated without credentials
jeffandersen added a commit that referenced this issue Nov 12, 2013
@jeffandersen
Pagination option names deviate from API docs (Closes #5)
4aeeb31
@jeffandersen jeffandersen mentioned this issue Nov 12, 2013
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pagination parameter names goinstant/rest-client
2 participants
@stash @jeffandersen