[Ajat|Baskara] set default flushBytes to LANStatsdFlushBytes

pkg/plugins/statsd_collector.go

@@ -5,6 +5,13 @@ import (
 	"time"
 )
 
+// https://github.com/etsy/statsd/blob/master/docs/metric_types.md#multi-metric-packets
+const (
+	WANStatsdFlushBytes     = 512
+	LANStatsdFlushBytes     = 1432
+	GigabitStatsdFlushBytes = 8932
+)
+
 type StatsdCollectorClient struct {
 	client     statsd.Statter
 	sampleRate float32
@@ -18,12 +25,15 @@ type StatsdCollectorConfig struct {
 	Prefix string
 	// StatsdSampleRate sets statsd sampling. If 0, defaults to 1.0. (no sampling)
 	SampleRate float32
-	// FlushBytes sets message size for statsd packets.
+	// FlushBytes sets message size for statsd packets. If 0, defaults to LANFlushSize.
 	FlushBytes int
 }
 
 func InitializeStatsdCollector(config *StatsdCollectorConfig) (*StatsdCollectorClient, error) {
 	flushBytes := config.FlushBytes
+	if flushBytes == 0 {
+		flushBytes = LANStatsdFlushBytes
+	}
 
 	sampleRate := config.SampleRate
 	if sampleRate == 0 {

pkg/plugins/statsd_collector_test.go

@@ -24,7 +24,7 @@ func TestInitializeStatsdCollector(t *testing.T) {
 	assert.Equal(t, float32(1), scc.sampleRate)
 
 	// Test Statter client
-	scc, err = InitializeStatsdCollector(&StatsdCollectorConfig{})
+	scc, err = InitializeStatsdCollector(&StatsdCollectorConfig{FlushBytes: 0})
 	assert.Nil(t, err)
 	assert.NotNil(t, scc)
 	assert.NotNil(t, scc.client)