Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage byte range support #49

Merged
merged 14 commits into from
Mar 3, 2020

Conversation

anggiaj
Copy link
Contributor

@anggiaj anggiaj commented Feb 18, 2020

No description provided.

@anggiaj anggiaj force-pushed the feature/byte-range-support branch 4 times, most recently from 1c8f5b0 to 413c51e Compare February 19, 2020 12:17
@anggiaj anggiaj changed the title [WIP] byte range support Storage byte range support Feb 20, 2020
pkg/storage/types.go Outdated Show resolved Hide resolved
pkg/storage/aws/cloudfront/storage.go Outdated Show resolved Hide resolved
@sonnes
Copy link

sonnes commented Feb 21, 2020

@anggiaj LGTM 👍 The changes are much cleaner and simpler now

Copy link
Member

@baskarap baskarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

internal/handler/image_test.go Outdated Show resolved Hide resolved
pkg/storage/aws/s3/storage.go Show resolved Hide resolved
pkg/storage/webfolder/storage.go Outdated Show resolved Hide resolved
gia added 2 commits February 25, 2020 11:15
… webfolder, make cloudfront.GetPartialObject consistent with s3.GetPartialObject
Copy link
Member

@baskarap baskarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baskarap baskarap merged commit c910e75 into gojek:master Mar 3, 2020
ajatprabha pushed a commit to ajatprabha/darkroom that referenced this pull request Jul 19, 2020
* Add response metadata

* Add byte range support for s3 client

* Add byte range support for cloudfront

* Add byte range support for webfolder

* Add GetPartialObject method on storage

* Remove GetPartialObject implementation from webfolder

* Make cloudfront.GetPartialObject consistent with s3.GetPartialObject

* Rename GetPartialObject method to GetPartially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants