-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage byte range support #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c8f5b0
to
413c51e
Compare
413c51e
to
76cda5e
Compare
76cda5e
to
88d0984
Compare
4a0d382
to
fb0a860
Compare
sonnes
reviewed
Feb 20, 2020
@anggiaj LGTM 👍 The changes are much cleaner and simpler now |
baskarap
reviewed
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
… webfolder, make cloudfront.GetPartialObject consistent with s3.GetPartialObject
baskarap
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ajatprabha
pushed a commit
to ajatprabha/darkroom
that referenced
this pull request
Jul 19, 2020
* Add response metadata * Add byte range support for s3 client * Add byte range support for cloudfront * Add byte range support for webfolder * Add GetPartialObject method on storage * Remove GetPartialObject implementation from webfolder * Make cloudfront.GetPartialObject consistent with s3.GetPartialObject * Rename GetPartialObject method to GetPartially
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.