Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing request buffer to create new reader on each request #34

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

dlahoza
Copy link
Contributor

@dlahoza dlahoza commented Jun 4, 2018

This PR resolves the issue with drained request payload buffer after the first request.
When you repeat the request with the same buffer, you should fill or seek to the beginning before next usage.

@rShetty
Copy link
Contributor

rShetty commented Jun 7, 2018

Thanks @Dlag for the PR, merging

@rShetty rShetty merged commit 6494102 into gojek:master Jun 7, 2018
@vthiery
Copy link
Contributor

vthiery commented Jun 11, 2018

Hi!
I actually spent some time today investigating an issue caused by the bug this PR fixes. I was based on 3.0.0 (the latest version) that does not contain this fix. This was rather unfortunate and lost a bit of time before realising master was fine.
Would it be possible to bump the latest version of the package to 3.0.1 (bug fix bump) to avoid someone else running into this issue?

@vthiery vthiery mentioned this pull request Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants