Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old module code purge on plugin disable #64

Merged
merged 1 commit into from
May 29, 2024

Conversation

VivekPipaliya23
Copy link

Proposed Changes

Previously, when we reloaded the plugin at runtime using vmq-admin, the old plugin module was not properly removed. This caused issues when trying to enable the new plugin.
The changes in this pull request (PR) will ensure that the old code is correctly deleted and Purged. When re-enabling, the system will always use the newer code from the specified path.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

@dhruvjain99 dhruvjain99 merged commit f00ea31 into main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants