Remove the error handling from implements-serializer

gojek · Apr 13, 2020 · 4d5bc18 · 4d5bc18
1 parent 241440e
commit 4d5bc18
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/ziggurat/producer.clj b/src/ziggurat/producer.clj
@@ -58,11 +58,8 @@
               ^{:static true} [send [String String int Object Object] java.util.concurrent.Future]]))
 
 (defn *implements-serializer?* [serializer-class]
-  (try
-    (contains? (set (.getInterfaces (Class/forName serializer-class)))
-               (Class/forName "org.apache.kafka.common.serialization.Serializer"))
-    (catch ClassNotFoundException e
-      false)))
+  (contains? (set (.getInterfaces (Class/forName serializer-class)))
+             (Class/forName "org.apache.kafka.common.serialization.Serializer")))
 
 (def implements-serializer? (s/pred *implements-serializer?* 'implements-serializer?))
 

diff --git a/test/ziggurat/producer_test.clj b/test/ziggurat/producer_test.clj
@@ -128,6 +128,10 @@
   (testing "with incorrect config"
     (let [valid-config (assoc valid-config :linger-ms-foo "1")]
       (is (thrown? java.lang.RuntimeException (producer-properties valid-config))))
+    (let [valid-config (update  valid-config :key-serializer-class (constantly  "java.time.Clock"))]
+      (is (thrown? java.lang.RuntimeException (producer-properties valid-config))))
+    (let [valid-config (update  valid-config :key-serializer-class (constantly  "java.foo.Bar"))]
+      (is (thrown? java.lang.RuntimeException (producer-properties valid-config))))
     (let [valid-config (dissoc valid-config :bootstrap-servers)]
       (is (thrown? java.lang.RuntimeException (producer-properties valid-config))))))