Refactoring Retry Logic for Exponential Retries #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjayprateek
commented
Jan 3, 2020
•
mjayprateek
commented
- Introduces retry types [:linear, :exponential]
- Removed the usage of retry-limits in case of exponential retries
- Introduces queue-timeout-ms for channels
:linear for enabling linear retries :exponential for enabling exponential backoff based retries
…ic retry-count and queue-timeout-ms values Earlier, if these values were not present in the a channel config, the channel retry flow would pick retry-count and queue-timeout-ms from Ziggurat config.
mjayprateek
force-pushed
the
refactoring_retries_logic
branch
from
38af3bf
to
bef4261
Compare
thediantoni
reviewed
Jan 9, 2020
Tests for make-queues Tests for get-backoff-exponent
thediantoni
reviewed
Jan 9, 2020
| (let [{:keys [queue-name exchange-name dead-letter-exchange]} (:delay (rabbitmq-config)) | ||
| queue-name (delay-queue-name topic-entity queue-name) | ||
| exchange-name (prefixed-queue-name topic-entity exchange-name) | ||
| dead-letter-exchange-name (prefixed-queue-name topic-entity dead-letter-exchange) | ||
| sequence (if (<= retry-count exponential-backoff-count) (inc retry-count) (inc exponential-backoff-count))] |
There was a problem hiding this comment.
exponential-backoff-count also used to control if we want to have exponential retry initially but after some retry it will be linear retry. how we can achieve it now?
There was a problem hiding this comment.
we're not supporting that anymore, I cannot think of a usecase where we'll need both linear and exponential retry in the same flow.
There was a problem hiding this comment.
IMO, it unnecessarily complicates things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.