refactors metrics.clj #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macalimlim
reviewed
Apr 15, 2020
src/ziggurat/metrics.clj
Outdated
| tagged-metric (.tagged ^MetricName metric-name tags)] | ||
| (.histogram ^MetricRegistry metrics-registry ^MetricName tagged-metric)))) | ||
| (defstate statsd-reporter | ||
| :start (metrics-lib/initialize (:datadog (ziggurat-config))) |
There was a problem hiding this comment.
yes rebased it.
There was a problem hiding this comment.
oh I mean get the config thru (config/statsd-config) because this behavior was changed on the previous commit
There was a problem hiding this comment.
will dropwizard be the default metrics implementation?
There was a problem hiding this comment.
oh, sure, will fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves dropwizard-metrics out of metrics.clj.
Pulls in defstate into metrics.clj.
Attempts to make metrics.clj library agnostic.