remove defrecord wrappers #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macalimlim
force-pushed
the
remove-wrappers
branch
from
063e092
to
0ad2b2e
Compare
macalimlim
force-pushed
the
remove-wrappers
branch
from
0ad2b2e
to
32a5d2b
Compare
shubhang93
reviewed
Jul 18, 2020
| If the message is of type map, the function just returns the map as it is. In older versions of Ziggurat (< 3.0) we stored | ||
| the messages in deserialized formats in RabbitMQ and those messages can be processed by this function. So we have this logic here." | ||
| [message proto-class topic-entity-name] | ||
| (reduce |
There was a problem hiding this comment.
Hey, why do we do a reduce here? Won't the message have this structure:-
{:topic-key1 "some_byte_array" :topic-key2 "some_byte_array"}
There was a problem hiding this comment.
Yes :) it will have that structure. reduce is in case we have to do multiple joins (two or more), for now its only one...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.