Lg rabbitmq retry #266
Lg rabbitmq retry #266
Conversation
src/ziggurat/messaging/producer.clj
Outdated
| (:count (channel-retry-config topic-entity channel))) | ||
|
|
||
| (defn get-configured-retry-count [] |
There was a problem hiding this comment.
This method should go inside ziggurat.config. Missed it while pairing
There was a problem hiding this comment.
ziggurat.config is giving whole configuration and we are only fetching rabbit-mq retry count which is required for our use case. So i feel this file is the right place for this method as other similar methods are already there.
There was a problem hiding this comment.
hmm. fine. since channel retry configuration is also coming from producer.clj, it seems fine. But, given that we're just fetching configuration and not doing anything produce specific, ziggurat.config would have been the right place even for getting channel retry count.
You can look at other helper methods in ziggurat.config
There was a problem hiding this comment.
Moved config as per suggestion, kindly check and merge.
mjayprateek
force-pushed
the
lg_rabbitmq_retry
branch
from
8f94e9c
to
862fccf
Compare
No description provided.