Fixes Issue #26 - Upgrade to kafka streams 2.0 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik7153
reviewed
Mar 25, 2019
kartik7153
reviewed
Mar 26, 2019
kartik7153
reviewed
Mar 26, 2019
kartik7153
approved these changes
Mar 27, 2019
theanirudhvyas
changed the title
…ulling kafka code
Co-authored-by: Kartik <rulz.gupta@gmail.com>
Co-authored-by: Kartik <rulz.gupta@gmail.com>
mjayprateek
pushed a commit
to mjayprateek/ziggurat
that referenced
this pull request
Jun 4, 2019
* Adds a docker-compose.yml and removes embedded kafka from integration tests * Adds docker-compose commands to travis-ci * runs docker-compose on travis in detached mode * fixes incorrect test * removes git hooks as they have been deprecated * refactors stream tests * Fixes ci: updates travis.yml to run tests for both kafka 1 and kafka 2 * removes deprecated method punctuate from timestamp transformer * updates kafka-streams version to 2.1.0 * Adds upgrade-from config for updating from kafka-streams 1 to 2 * refactors streams.clj, moves offset-reset-config validation out into a function * adds a .env file to set default KAFKA_VERSION for docker-compose * refactors ci: creates topic from within docker container instead of pulling kafka code * moves logic for running tests in ci out into a script * moves the upgrade-from config to stream-routes * all integration stream tests now run with different application-ids * refactors code and introduces lint stage in ci * Adds a make-file and changes container name in docker-compose * Adds rabbitmq to docker-compose * removes duplicate import from streams.clj * Runs make test-all command in ci * refactors code, stream-tests get values from config. * Updates dev-setup in readme * Add changelog-topic-replication to test * Add code-coverage stage in CI pipeline
mjayprateek
pushed a commit
to mjayprateek/ziggurat
that referenced
this pull request
Jun 4, 2019
* Adds a docker-compose.yml and removes embedded kafka from integration tests * Adds docker-compose commands to travis-ci * runs docker-compose on travis in detached mode * fixes incorrect test * removes git hooks as they have been deprecated * refactors stream tests * Fixes ci: updates travis.yml to run tests for both kafka 1 and kafka 2 * removes deprecated method punctuate from timestamp transformer * updates kafka-streams version to 2.1.0 * Adds upgrade-from config for updating from kafka-streams 1 to 2 * refactors streams.clj, moves offset-reset-config validation out into a function * adds a .env file to set default KAFKA_VERSION for docker-compose * refactors ci: creates topic from within docker container instead of pulling kafka code * moves logic for running tests in ci out into a script * moves the upgrade-from config to stream-routes * all integration stream tests now run with different application-ids * refactors code and introduces lint stage in ci * Adds a make-file and changes container name in docker-compose * Adds rabbitmq to docker-compose * removes duplicate import from streams.clj * Runs make test-all command in ci * refactors code, stream-tests get values from config. * Updates dev-setup in readme * Add changelog-topic-replication to test * Add code-coverage stage in CI pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK LEFT: Add tests for upgrade.from config usage in streams..
Ziggurat is now tested across different Kafka versions in the CI.
We have added a docker compose that is now used for integration tests instead of embedded Kafka.
Have added the config
upgrade.fromthat is required for upgrading services using ziggurat from kafka_streams 1.x to 2.1.0.Removes git-hooks (as they are deprecated)
Refactors code