move dead set functions into messaging.dead-set namespace #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjayprateek
approved these changes
Aug 21, 2019
|
@satyanash what was your rationale behind doing this refactoring? |
|
I do not want rabbitMQ specific logic (langohr) to leak out of the consumer namespace, with the refactoring that you have done, dead-set also has rabbitMQ specific logic now. |
|
|
||
| (defn- try-consuming-dead-set-messages [ch ack? queue-name topic-entity] | ||
| (try | ||
| (let [[meta payload] (lb/get ch queue-name false)] |
There was a problem hiding this comment.
I wish to keep the rabbitMQ logic encapsulated in consumer namespace, what if we keep this function in consumer namespace itself or abstract it out some other way?
|
Hey @satyanash, seems you are no longer working on this. I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move dead set functions into
messaging.dead-setnamespace