Json middleware #97
Merged
Json middleware #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfn
reviewed
Oct 10, 2019
kartik7153
reviewed
Oct 10, 2019
kartik7153
reviewed
Oct 10, 2019
| [message topic-entity-name key-fn] | ||
| (try | ||
| (parse-string message key-fn) | ||
| (catch Exception e |
There was a problem hiding this comment.
@kartik7153 Because, Cheshire library does not say which exceptions can be thrown.
kartik7153
reviewed
Oct 10, 2019
src/ziggurat/middleware/json.clj
Outdated
| If `true`, would coerce keys to keywords, and if `false` it would leave keys as strings. | ||
| Default value is true." | ||
| ([handler-fn topic-entity-name] | ||
| (parse-json handler-fn topic-entity-name true)) |
There was a problem hiding this comment.
@kartik7153 true is the value of key-fn which is the third argument to parse-json.
…arse-json middleware function
mjayprateek
force-pushed
the
json_middleware
branch
from
0f60e55
to
50923da
Compare
@irfn I've added that in |
|
IMO this should be part of a separate library. @irfn, @mjayprateek mentioned that he had a conversation with you around keeping this in Ziggurat itself. |
IMHO By this rationale i would keep json in core. |
mjayprateek
force-pushed
the
json_middleware
branch
from
b03c20b
to
c19cbf7
Compare
mjayprateek
force-pushed
the
json_middleware
branch
from
c19cbf7
to
41da665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.