Making key and value serdes configurable for enabling JSON (de)serialization #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c0f868.
…d deserializer.encoding configs for use within String Serde
mjayprateek
force-pushed
the
json_middleware
branch
from
e00b1b9
to
f0f6619
Compare
| :enable-idempotence false | ||
| :value-serializer "org.apache.kafka.common.serialization.StringSerializer" | ||
| :key-serializer "org.apache.kafka.common.serialization.StringSerializer"}} | ||
| :with-key-val-serdes {:application-id "test" |
There was a problem hiding this comment.
why have you added a separate topic-entity for this. Why not mock config in the test and add or remove values there? This is causing unnecessary repitition in config of this file.
| :enable-idempotence false | ||
| :value-serializer "org.apache.kafka.common.serialization.StringSerializer" | ||
| :key-serializer "org.apache.kafka.common.serialization.StringSerializer"}} | ||
| :with-key-val-serdes {:application-id "test" |
| "This namespace defines middleware methods for parsing JSON strings. | ||
| Please see [Ziggurat Middleware](https://github.com/gojek/ziggurat#middleware-in-ziggurat) for more details. | ||
| " | ||
| (:require [cheshire.core :refer :all] |
There was a problem hiding this comment.
please use namespaced function names instead of :refer :all https://github.com/bbatsov/clojure-style-guide#prefer-require-over-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted the earlier commit where byte array message was converted to String before parsing as JSON
Changed streams.clj to accept any serde. Earlier, byte array was hard-coded.