Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go sum update #15

Merged
merged 3 commits into from
Feb 15, 2019
Merged

go sum update #15

merged 3 commits into from
Feb 15, 2019

Conversation

irfn
Copy link

@irfn irfn commented Feb 15, 2019

Build failing due to. Updated by regenerating go.sum

go: verifying github.com/coreos/etcd@v3.3.0+incompatible: checksum mismatch
        downloaded: h1:v3H7yHgF+94suF7Xg6V7Haq6Anac3X6WosuKGTTJCGM=
        go.sum:     h1:WyMdmwfw02n2i3gTkzy+HBR2dsh1axjxn808iAe9PLI=

@irfn irfn requested a review from rShetty February 15, 2019 11:25
@rShetty
Copy link
Contributor

rShetty commented Feb 15, 2019

Checks are failing

@irfn
Copy link
Author

irfn commented Feb 15, 2019

Checks are failing

This was due to version differences. Have updated Dockerfile and travis config.
Can squash the commits.

@rShetty
Copy link
Contributor

rShetty commented Feb 15, 2019

Cool squashing and merging

@rShetty rShetty merged commit d662aa6 into gojek:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rShetty rShetty Awaiting requested review from rShetty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfn @rShetty