switched to goji2

[jdoklovic]

No description provided.

[saj1th]

@jdoklovic thanks a lot for contributing. do you want to consider creating another repo for goji2 logrus middleware. something similar to how @elithrar created https://github.com/goji/ctx-csrf and https://github.com/goji/csrf

[jdoklovic]

@saj1th I'd love to have it under goji/glogrus I'd also like to get the request_id middleware in there as well.
Is there a way I can get rights to make a new repo under goji?

[elithrar]

@jdoklovic Create an issue on https://github.com/goji/goji and request:

• Name of the repo(s)
• Description to put above it
• What you want to achieve

Note that I already created https://github.com/elithrar/goji-logger here - which is effectively a port of middleware.Logger and middleware.RequestID from Goji v1 to Goji v2.

[jdoklovic]

Cool... couple things though.

1. there's already this repo which is named goji/glogrus but it's still goji v1. Seems like the PR I submitted should go here since goji/* seems to be all v2 stuff. (I'm happy to create glogrus2 though)
2. I've just added support for passing a function which takes the context and returns a requestId. This makes request id lookups "pluggable". e.g. it can be provided by any other middleware. You might want to consider it for your logger as well. see: atlassian@69a9fbb

[saj1th]

@jdoklovic I'm not entirely sure about the direction of repositories under https://github.com/goji/ . I guess in its current state it contains both v1 and v2 repos

The reason I suggested a different repo is - there are few people who use github.com/zenazn/goji & github.com/goji/glogrus in production & goji2 changes would make glogrus incompatible with zenazn/goji

@zenazn would be the best person to shed some light here

[jdoklovic]

@saj1th I realized that was all leftover anyway.
I've simplified and added the support for pluggable requestId middleware:
atlassian@544444b

[jdoklovic]

@saj1th @elithrar FYI: https://github.com/atlassian/gojiid
see that for examples of how/why there's the added requestId stuff in my new glogrus code

[jdoklovic]

Closing due to new repo being created