New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove golint errors about string as context key #42

Merged

zenazn merged 2 commits into goji:go17 from unknown repository

Oct 25, 2016

ghost commented Oct 25, 2016

While I was vendoring goji in my project, I had golint errors about not using basic type string as key in context.WithValue.

I removed the error using a pattern.Variable in place of string.

François Bastien added 2 commits

October 25, 2016 12:04


          remove golint errors about string as context key

e2da90d


          bugfix: pass the test

507dc11

zenazn merged commit 6c7f26e into goji:go17

Member

zenazn commented Oct 25, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment