Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geocode): add geocode #5

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Conversation

miramo
Copy link
Member

@miramo miramo commented Feb 28, 2019

fixes #4

@miramo miramo force-pushed the feature/implements_geocode_api branch from f5e829c to 34cd9bb Compare February 28, 2019 17:53
@coveralls
Copy link

coveralls commented Feb 28, 2019

Pull Request Test Coverage Report for Build 27

  • 26 of 26 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 95.833%

Totals Coverage Status
Change from base Build 21: 1.2%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

@miramo miramo requested a review from VinceOPS March 1, 2019 09:13
/** For a given `type`, provide a predicate looking for `type` in the types of the input component */
const findByType = (type: PlaceType) => (component: IGoogleAddressComponent) => component.types.includes(type);

export function extractAddress(address_components: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 (no Doc nor test but who cares?! 😂 it wasn't tested; already 😏 )

@VinceOPS VinceOPS merged commit c4f6785 into master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imlements geocode API
4 participants