Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #issue16 #22

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix #issue16 #22

merged 1 commit into from
Aug 2, 2022

Conversation

chriskaliX
Copy link
Contributor

I've look into the code of both bcc and data-dog's. Here is the summary:

  1. In data-dog‘s way, if a kprobe function name is specific(which means no prefix is needed), it won't be added a prefix dynamically.
  2. In bcc, a cache of the text section and weak symbol is used.

In order to not change the way we use(no extra field for kprobe function name specification), I choose the second way(bcc), which will cache data for about 1M, and for sure, we have to run an extra loop to cache the symfile, which I think is acceptable.

@chriskaliX chriskaliX requested a review from cfc4n August 2, 2022 08:24
@chriskaliX chriskaliX added the enhancement New feature or request label Aug 2, 2022
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cfc4n cfc4n merged commit 3198c8a into gojue:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants