Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: init GoTLSProbe.tcPacketsChan #492 #493

Merged
merged 2 commits into from Feb 28, 2024
Merged

Conversation

ruitianzhong
Copy link
Contributor

  • initialize tcPacketsChan in MTCProbe of GoTLSProbe
  • filled mod.name and mod.mType in probe_gotls.go::init() used for debugging

The problem mentioned in issure #492 is caused by uninitialized tcPacketsChan in GoTLSProbe.

When code is executed, eOverflow is returned which turn out to be the error message mentioned in issue #492

ruitianzhong and others added 2 commits February 27, 2024 19:17
* init tcPacketsChan in MTCProbe of GoTLSProbe
* filled mod.name and mod.mType in probe_gotls.go::init() used for debugging

Signed-off-by: ruitianzhong <ruitian-zhong@outlook.com>
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfc4n cfc4n merged commit 286bdcf into gojue:master Feb 28, 2024
6 checks passed
@ruitianzhong ruitianzhong deleted the bug-fix branch February 28, 2024 01:13
@cfc4n cfc4n added the bug Something isn't working label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants