Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -race flags for go test and fix data race warning #499

Merged
merged 1 commit into from Mar 2, 2024
Merged

add -race flags for go test and fix data race warning #499

merged 1 commit into from Mar 2, 2024

Conversation

ruitianzhong
Copy link
Contributor

When add -race to go test , several data race warnings are raised.

first one(data race for workerqueue in EventProcessor):

WARNING: DATA RACE
Read at 0x00c000098c30 by goroutine 7:
  ecapture/pkg/event_processor.(*EventProcessor).Close()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:118 +0xb04
  ecapture/pkg/event_processor.TestEventProcessor_Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:77 +0xb29
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1742 +0x44

Previous write at 0x00c000098c30 by goroutine 9:
  runtime.mapdelete_faststr()
      /usr/local/go/src/runtime/map_faststr.go:301 +0x0
  ecapture/pkg/event_processor.(*EventProcessor).delWorkerByUUID()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:105 +0xed
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:152 +0x99
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Goroutine 7 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1742 +0x825
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:2161 +0x85
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1689 +0x21e
  testing.runTests()
      /usr/local/go/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:2027 +0xf17
  main.main()
      _testmain.go:47 +0x2bd

Goroutine 9 (finished) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

the second one (data race HttpRequest and HttpResponse but they are benign data race):

WARNING: DATA RACE
Write at 0x00c000078100 by goroutine 13:
  ecapture/pkg/event_processor.(*HTTPRequest).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_request.go:88 +0x1f2
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Previous write at 0x00c000078100 by goroutine 9:
  ecapture/pkg/event_processor.(*HTTPRequest).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_request.go:88 +0x1f2
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Goroutine 13 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

Goroutine 9 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25
==================
==================
WARNING: DATA RACE
Write at 0x00c0000162c0 by goroutine 10:
  ecapture/pkg/event_processor.(*HTTPResponse).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_response.go:104 +0x1f8
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Previous write at 0x00c0000162c0 by goroutine 12:
  ecapture/pkg/event_processor.(*HTTPResponse).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_response.go:104 +0x1f8
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Goroutine 10 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

Goroutine 12 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

@ruitianzhong
add -race flags for go test and fix data race warning
d70e863 
Signed-off-by: ruitianzhong <ruitian-zhong@outlook.com>
cfc4n
cfc4n approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

pkg/event_processor/http_request.go Show resolved Hide resolved
@cfc4n cfc4n merged commit b2aeb73 into gojue:master Mar 2, 2024
6 checks passed
@ruitianzhong ruitianzhong deleted the race-check branch March 2, 2024 12:42
@cfc4n cfc4n added the enhancement New feature or request label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfc4n cfc4n cfc4n approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruitianzhong @cfc4n