[WIP] "Orchestrator like" execution mode #138

tagantroy · 2018-04-20T10:44:59Z

#135 implementation

Add dependency
Implement test parser
add buildSingleTestArguments

artem-zinnatullin · 2018-04-20T21:53:55Z

composer/src/main/kotlin/com/gojuno/composer/Apk.kt

+                .value()
+
+fun parseTests(testApkPath: String) = DexParser.findTestMethods(testApkPath)


Can you please specify return type explicitly here?

artem-zinnatullin · 2018-04-20T21:54:04Z

composer/src/main/kotlin/com/gojuno/composer/Apk.kt

@@ -3,6 +3,9 @@ package com.gojuno.composer
 import com.gojuno.commander.android.aapt
 import com.gojuno.commander.os.Notification
 import com.gojuno.commander.os.process
+import com.linkedin.dex.parser.DexParser
+import com.linkedin.dex.parser.TestMethod


looks unused :)

artem-zinnatullin · 2018-04-20T21:54:47Z

@dsvoronin PTAL

artem-zinnatullin · 2018-04-21T03:15:10Z

composer/src/main/kotlin/com/gojuno/composer/Apk.kt

We can add an integration test (we already have some that parse runner from test apk, you can add couple tests there)

Not that I don't trust this library, but it can help catch future regressions!

…ests

tagantroy · 2018-04-21T03:28:59Z

@artem-zinnatullin
what do you think about 2 strategies:

execute all test on each device
all devices poll from common queue

dsvoronin · 2018-04-21T13:54:38Z

composer/src/main/kotlin/com/gojuno/composer/Apk.kt

+                .value()
+
+fun parseTests(testApkPath: String) : List<String> =


Seems like we need to keep TestMethod, to filter out @Ignore before run and keep custom annotations info

Ideally we'd have own TestMethod objects (we have some, I'm not sure they cover this use-case), so plugins (see below) could extend it with custom info and Dexparser lib would be just implementation detail rather than API everyone has to use

yep, i'm all into this kind of abstraction

dsvoronin · 2018-04-21T13:56:57Z

composer/src/main/kotlin/com/gojuno/composer/Apk.kt

+                .value()
+
+fun parseTests(testApkPath: String) : List<String> =


Also, we need handling of our own annotations to modify resulting junit report. How this can be possible without forking composer? Any plugin mechanism?

answering my own question: probably we need something like this

Yeah, we discussed plugins before, it shouldn't be super hard since we're running Composer on JVM. We can add a parameter to load plugin(s) as jars and can add abstractions and APIs to hook into

@dsvoronin can you please create a separate issue for Plugin System?

dsvoronin · 2018-04-21T14:24:02Z

what do you think about 2 strategies:

execute all test on each device

all devices poll from common queue

I'm not Artem :) , but we need at least all devices poll from common queue strategy. We spawn N exact clones, and they polls from queue.

We definitely need abstraction for different strategies here

artem-zinnatullin · 2018-04-21T22:09:18Z

I'd start with just integrating Orchestrator-like process isolation into current shart true/false mode

Dynamic test sharding is just something we can build on top of test parsing, we should allow running dynamically sharded tests without "Orchestrator" right

yunikkk · 2018-04-23T09:19:29Z

+1 for polling from the main queue and having in mind other strategies in future.

yunikkk · 2018-04-23T09:25:43Z

composer/src/main/kotlin/com/gojuno/composer/Main.kt

@@ -198,6 +198,11 @@ private fun List<String>.pairArguments(): List<Pair<String, String>> =
            }
        }

+


nit: remove extra line above/below function

yunikkk · 2018-04-23T09:26:13Z

composer/src/test/kotlin/com/gojuno/composer/ApkSpec.kt

@@ -18,5 +18,8 @@ class ApkSpec : Spek({
        it("parses test package correctly") {
            assertThat(parseTestPackage(testApkPath)).isEqualTo(TestPackage.Valid("test.test.myapplication.test"))
        }
+        it("parses tests list correctly") {


nit: extra line?

artem-zinnatullin · 2018-04-24T18:04:44Z

LGTM, let's merge as first part?

yunikkk · 2018-04-24T20:15:34Z

@artem-zinnatullin yup, the only question is unchecked "Execute list of tests", @tagantroy are you going to add smth here?

tagantroy · 2018-04-25T02:22:20Z

@artem-zinnatullin @yunikkk let's merge it

yunikkk · 2018-04-25T09:02:10Z

@tagantroy merged

tagantroy added 2 commits April 20, 2018 18:31

add dex parser dependency

c432d98

implement parseTests function

e5982da

yunikkk requested review from yunikkk and artem-zinnatullin April 20, 2018 21:34

artem-zinnatullin suggested changes Apr 20, 2018

View reviewed changes

specify return type and removed unused import

c5aae4a

artem-zinnatullin reviewed Apr 21, 2018

View reviewed changes

tagantroy added 2 commits April 21, 2018 11:19

return List<String> instead of List<TestMethod> as a result of parseT…

b6f07b2

…ests

add parseTests test

8a3b577

Merge branch 'master' into feature/execute_tests_independently

802dae4

dsvoronin reviewed Apr 21, 2018

View reviewed changes

yunikkk reviewed Apr 23, 2018

View reviewed changes

tagantroy added 5 commits April 24, 2018 21:41

fix code style

373684d

add TestMethod data class

2906a3e

change parseTests return try to List<TestMethod>

01c9f5e

format TestMethod

1724c97

remove extra lines

7ab8a92

artem-zinnatullin approved these changes Apr 24, 2018

View reviewed changes

Merge branch 'master' into feature/execute_tests_independently

8fb44a0

yunikkk merged commit c4e7668 into gojuno:master Apr 25, 2018

artem-zinnatullin mentioned this pull request May 15, 2018

Add Test Orchestrator support. #90

Closed

dsvoronin mentioned this pull request Jun 7, 2018

Pooling Strategies MarathonLabs/marathon#24

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] "Orchestrator like" execution mode #138

[WIP] "Orchestrator like" execution mode #138

tagantroy commented Apr 20, 2018 •

edited

Loading

artem-zinnatullin Apr 20, 2018

artem-zinnatullin Apr 20, 2018

artem-zinnatullin commented Apr 20, 2018

artem-zinnatullin Apr 21, 2018

tagantroy commented Apr 21, 2018

dsvoronin Apr 21, 2018 •

edited

Loading

artem-zinnatullin Apr 21, 2018

dsvoronin Apr 22, 2018

dsvoronin Apr 21, 2018

dsvoronin Apr 21, 2018

artem-zinnatullin Apr 21, 2018

dsvoronin Apr 22, 2018

dsvoronin commented Apr 21, 2018 •

edited

Loading

artem-zinnatullin commented Apr 21, 2018

yunikkk commented Apr 23, 2018

yunikkk Apr 23, 2018

yunikkk Apr 23, 2018

artem-zinnatullin commented Apr 24, 2018

yunikkk commented Apr 24, 2018

tagantroy commented Apr 25, 2018

yunikkk commented Apr 25, 2018

		.value()

		fun parseTests(testApkPath: String) = DexParser.findTestMethods(testApkPath)

		.value()

		fun parseTests(testApkPath: String) : List<String> =

		@@ -198,6 +198,11 @@ private fun List<String>.pairArguments(): List<Pair<String, String>> =
		}
		}

[WIP] "Orchestrator like" execution mode #138

[WIP] "Orchestrator like" execution mode #138

Conversation

tagantroy commented Apr 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artem-zinnatullin commented Apr 20, 2018

Choose a reason for hiding this comment

tagantroy commented Apr 21, 2018

dsvoronin Apr 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsvoronin commented Apr 21, 2018 • edited Loading

artem-zinnatullin commented Apr 21, 2018

yunikkk commented Apr 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artem-zinnatullin commented Apr 24, 2018

yunikkk commented Apr 24, 2018

tagantroy commented Apr 25, 2018

yunikkk commented Apr 25, 2018

tagantroy commented Apr 20, 2018 •

edited

Loading

dsvoronin Apr 21, 2018 •

edited

Loading

dsvoronin commented Apr 21, 2018 •

edited

Loading