feat: add argument to speecify custom mock names #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #56 |
damianopetrungaro
force-pushed
the
master
branch
2 times, most recently
from
641a790
to
a87ec7c
Compare
hexdigest
requested changes
Jun 18, 2021
There was a problem hiding this comment.
Hey @damianopetrungaro, thank you for making it real! :) I was thinking about this for a couple of years already.
| if *aliases != "" { | ||
| mockNames = strings.Split(*aliases, ",") | ||
| } | ||
| if len(mockNames) != 0 && len(mockNames) != len(interfaces) { |
There was a problem hiding this comment.
Can you please make sure that -i option doesn't contain any wildcards when -n is given? This will generate mock with the same name for every interface in the package. Let's say we have -i io.* -n IOMock then we'll have same IOMock name for both io.Reader and io.Writer.
There was a problem hiding this comment.
@hexdigest done :)
damianopetrungaro
force-pushed
the
master
branch
from
a87ec7c
to
912133c
Compare
|
No rush, just wanna make sure this one doesn't end lost in your notification in the same way as some of the PR I need to review 😄 |
|
Thank you Damian! |
|
@damianopetrungaro this should be working in v3.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to duplicate the tests since those can't use (easily) table-driven tests due to the nested mock operations needed.