Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r32 changelog #1427

Closed
gokcehan opened this issue Sep 17, 2023 · 10 comments
Closed

r32 changelog #1427

gokcehan opened this issue Sep 17, 2023 · 10 comments

Comments

@gokcehan
Copy link
Owner

gokcehan commented Sep 17, 2023

Changelog

@gokcehan gokcehan pinned this issue Sep 17, 2023
@joelim-work
Copy link
Collaborator

I will help to update this changelog from time to time. Feel free to reword/rewrite any entries as you like.

@joelim-work
Copy link
Collaborator

I have merged a few more PRs, all of which are small, primarily to maintain the progress of lf development, and keep the outstanding PR count low.

@gokcehan
Copy link
Owner Author

@joelim-work Sorry to disappear for a long time and thank you very much keeping everything in order. I will try to go over the PRs that you already approved and merge them in the upcoming days. I will also try to drop some comments in discussions where my feedback is requested.

I should note that I often try to skim through issues and PRs daily even though I'm not actively participating in discussions myself. I might try to join if I realize something that can be considered a red flag. So feel free to merge patches more liberally when I'm not around. I owe to participate in discussions at the very least if I want to be included in the decision making process. This also includes things that I have objected against before in the past (e.g. fsnotify)

Having said that, it feels a little strange that you are much more active than I am in a repository with my name. We can bring up the possibility of creating an organization if it can make you more comfortable. Let me know if you are interested in this and I will take a look at what we can do.

Happy holidays and see you after your break.

@joelim-work
Copy link
Collaborator

@gokcehan Thanks, hope you had a good break too, also happy new year to you.

Normally I try to avoid directly tagging you, but sometimes there are decisions that are controversial in nature, or are otherwise difficult to decide on, and I will seek feedback from you. I have also lately found myself to be on the conservative side when it comes to decision-making (e.g. rejecting PRs or feature requests where they either extremely niche and/or could be achieved via user configuration).

Regarding the idea of changing the repository ownership to a GitHub organization, perhaps it's another way of opening up the project to more users who wish to contribute, but I have honestly not given this much thought. I was actually thinking of slightly decreasing my activity here (compared to the previous year), partly for myself, but also to give others the opportunity to participate in the development of lf. For now I don't see myself developing any new features, maybe some bug fixes, reviewing PRs and responding to issues/questions.

Anyway I think things are fine as they are now, you don't have to change anything if you don't want to.

@gokcehan
Copy link
Owner Author

gokcehan commented Mar 6, 2024

@joelim-work Thank you very much for keeping the notes up to date. I guess there is nothing else we need for the release now.

About the timing of the release, I will be a little busy in the next two days. Maybe I can take a look at this in the weekend or next week. Or alternatively maybe you can try to do the release yourself this time. I'm curious if there is still anything required on my side to make a new release, and this could be a nice opportunity to give it a try.

To make a new release, the only thing required is the following (we could also have these in our documentation somewhere):

  1. Create a new tag and push it to github
  2. Add the release notes to the corresponding release on github after the builds are finished and the artifacts are uploaded
  3. Send an email to the mailing list

@gokcehan
Copy link
Owner Author

gokcehan commented Mar 6, 2024

@joelim-work Forgot to mention, we also need to update the documentation if it is not up to date yet.

By the way, I just realized we have this in our CONTRIBUTING.md:

Run gen/doc-with-docker.sh to update the documentation

Perhaps we should add "optionally" or something similar to this sentence to avoid the hard requirement of docker for contributions.

@joelim-work
Copy link
Collaborator

Hi @gokcehan I'm not really sure about taking over the release process, I still prefer to leave it to you as it is your project, although I don't mind things like reviewing the incoming PRs, and updating the generating documentation every now and then.

Regarding the actual release itself, it doesn't have to be this week or anything - it's not that urgent. I was just suggesting it because it's been a while since the last release. Maybe it might be better to wait for a couple of weeks anyway as a freeze period.

@gokcehan
Copy link
Owner Author

gokcehan commented Mar 9, 2024

@joelim-work A couple of weeks freeze period sounds good then.

@gokcehan
Copy link
Owner Author

@joelim-work I was planning to make a release today, but there seems to be some patches that can be considered bug fixes, so I think maybe we should merge them and leave the release for another week.

@joelim-work
Copy link
Collaborator

joelim-work commented Mar 24, 2024

@gokcehan That's fine, I didn't expect so many PRs would be created in the last couple of weeks. I am not in a rush for these kind of things anyway.

BTW I have written a regex to check for incorrectly formatted lines in the changelog, I'm not sure how you verify them otherwise:

grep -vE '^- \*\*\((Breaking|New|Fix)\)\*\* .+ \([0-9]+\) \(by [^ ]+\)\.$' <filename>

@gokcehan gokcehan changed the title r32 changelog (preview) r32 changelog Mar 31, 2024
@gokcehan gokcehan unpinned this issue Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants