New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permission denied #447
Comments
@johnhk Looking at release notes, it seems that permission denied errors were introduced in r13. Before that these were simply shown as empty directories without an error. If you're sure this was introduced in r15, this might be related to something different. Are you able to read those directories without using |
Thx for quick reply. I am able to navigate via cd and have access to the folders. And It if only version r15. r14 works fine. btw. sorry I didnt even write any specifics about system or situation. |
Havent quit figured it out yet. |
I can reproduce the behavior. It seems to happen on most folders on r15 C:\Users\myuser\AppData\Local\Temp>cat lf.myuser.1000.log
2020/08/17 21:29:00 hi!
2020/08/17 21:29:00 reading directory: readlink C:\Users\All Users: Access is denied.
2020/08/17 21:29:00 reading directory: readlink C:\Documents and Settings: Access is denied.
2020/08/17 21:29:00 loading files: []
2020/08/17 21:29:00 reading directory: readlink C:\Users\myuser\Application Data: Access is denied. |
I have now tried this on my windows machine and unfortunately I can't reproduce the behavior, that is All three folders in your examples seem to be hidden protected folders. These do not show in @johnhk Can you make sure you're running @pviotti What exactly do you mean by reproducing the behavior? Did you try this with versions older than r15? Do you have a different behavior with |
I created a throwaway virtual machine with Windows 10. Then I downloaded the binaries of r13, r14 and r15. if I run lf r15 on my user directory (which I can browse with explorer and powershell) I get this: So it looks like there may be some regression for Windows between r14 and r15. |
@pviotti Thank you for testing it throughly. I tried to download r15 from releases page and I can now reproduce the issue myself. Marking this as a bug. Before, I was testing it by checking out to an older release in the repository and then building it myself on my machine. My machine has It says in go1.13 release notes:
On I will change error handling in this change to fix the bug and also maybe bump the go version in our automated build system. Maybe it is a good idea to make a new release after this as well. If you have go installed (>=1.13), you should be able to build from the source as a workaround for now. In retrospect, I should have found the related change in |
I have now changed error handling to make it work with <go1.13 as well and also bumped our travis version to go1.15. A new release r16 is now available with the fix. Closing this issue. |
Fix colour construction issue This also has a test to mitigate it in the future Remove `colormode` option The original issue it was trying to solve is no longer present with tcell (it being a holdover from `color256` on termbox) so it is not needed. retire gitter channel in favor of irc/matrix Export options as environment variables (gokcehan#448) * Export options as environment variables Any options from gOpts are available via lf_OPTION environment variables. For now it works only on booleans, integers and strings (no array support) * Do not export some of the options * Add support for arrays and fix numbers * Fix comments * Replace 1 and 0 with true and false * Export hidden,reverse,dirfirst and sortby options * Fix comments * Little fix * Simplify boolean conversion log readlink errors instead of fail Related gokcehan#447 and gokcehan#374
Fix colour construction issue This also has a test to mitigate it in the future Remove `colormode` option The original issue it was trying to solve is no longer present with tcell (it being a holdover from `color256` on termbox) so it is not needed. retire gitter channel in favor of irc/matrix Export options as environment variables (#448) * Export options as environment variables Any options from gOpts are available via lf_OPTION environment variables. For now it works only on booleans, integers and strings (no array support) * Do not export some of the options * Add support for arrays and fix numbers * Fix comments * Replace 1 and 0 with true and false * Export hidden,reverse,dirfirst and sortby options * Fix comments * Little fix * Simplify boolean conversion log readlink errors instead of fail Related #447 and #374
I am using Manjaro Linux. I am getting 'Permission Denied' error when I am trying to delete a file/folder on my FTP server. But I am able to delete the file/folder through the terminal |
downloaded version r15 and Im getting "Permission denied" on almost all folders.
Reverted bak to an older version I had in a backup folder (r10) and no more "Permission denied".
Any Ideas?
log file:
2020/08/14 11:36:03 hi!
2020/08/14 11:36:03 reading directory: readlink C:\Users\All Users: Access is denied.
2020/08/14 11:36:03 reading directory: readlink C:\Documents and Settings: Access is denied.
2020/08/14 11:36:03 reading directory: readlink C:\Users<myname>\Application Data: Access is denied.
...
just checked the lf.exe's backwards in the release history. Looks like my problem was introduced from r14-->r15
The text was updated successfully, but these errors were encountered: