Is lf supposed to clear screen when switching to shell?

[ivanp7]

I have updated to r21 and have noticed that shell opened from lf is always fresh (without older output), which hasn't been happening before (I could execute some commands, launch lf, switch to shell and see previous terminal contents). Is this supposed to happen, or is this a bug?

[gokcehan]

@ivanp7 There is also previous ui drawings left in the terminal history. This was not intentional and we should mark this as a bug.

It is possible that this issue is related to the extra error we started receiving in our log files as mentioned in #480 . I think maybe somehow we can't switch to alternate screen for ui drawings after ui suspend/resume. I can also reproduce this on tcell mouse demo so it is possible that a fix requires a change in tcell as well.

[ivanp7]

Yeah, it looks like the problem is related to alternate screen. Also, I observed this behavior in Linux virtual terminals before r21, but thought it is not lf issue.

[gokcehan]

@ivanp7 Linux virtual terminal does not support alternate screen as far as I know so there is nothing much we can do about it. Other terminal programs also leaves ui artifacts after exiting. I think maybe there is only a difference for clearing the screen or not after exiting.

This issue indeed turned out to be an alternate screen issue. I think there is an easy fix for it. I have send it as a PR to the upstream as gdamore/tcell#439 . Let's see how it goes.

[ivanp7]

@gokcehan Good job, thank you!

[gokcehan]

@ivanp7 It looks like it might take a while for the patch to be merged and this seems like an annoying issue so I have switched to a local fork and this should now be working as expected in our master branch.

[roachsinai]

@gokcehan works well use aur lf-git for now, thanks!

[ivanp7]

@gokcehan Wow, very nice, thanks!