Display zero when relativenumber is enabled #1171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the formatting of line numbers, I think it's simpler and more readable to just pass in
lnwidth
as an argument to the format specifier, as opposed to building an intermediary format string.Also I don't think it's necessary to specify precision for integers, so I have removed it. In fact, this was probably why the original pull request #133 didn't display a zero when
relativenumber
is enabled - I have found thatfmt.Sprintf("[%1d]", 0)
results in[0]
whilefmt.Sprintf("[%1.d]", 0)
results in[ ]
.