Fix a few completion bugs and add a few small features #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-ouellette
force-pushed
the
unicode-complete
branch
from
d1a213a
to
a972afa
Compare
- matchLongest now operates on runes instead of bytes so we don't complete part of a multibyte character. - Fix some places that mixed string and rune slice indices.
When selecting a menu completion for a file in a subdirectory, the entire filename would be appended to the command line, even if you had already typed part of it.
p-ouellette
force-pushed
the
unicode-complete
branch
from
a972afa
to
fef5f69
Compare
p-ouellette
changed the title
The first use of cmd-menu-complete-back after opening the completion menu was incorrectly selecting the before-last completion instead of the last completion.
Also skip files with stat errors instead of returning.
p-ouellette
commented
Sep 27, 2022
Comment on lines
-283
to
-285
| f, err := os.Stat(name) | ||
| f, err := os.Lstat(name) | ||
| if err != nil { | ||
| fl, err := os.Lstat(name) |
There was a problem hiding this comment.
I'm not sure why this was doing a stat and an lstat. Maybe the stat is for the isDir check later that adds a trailing path separator. However on my Linux machine lstat on a symlink that points to a directory returns a FileInfo with the directory mode bit set, and this behavior is required by POSIX.1-2008.
This is useful when completing filenames. For example
cmap <c-y> :cmd-menu-accept; cmd-menu-complete
can be used to accept the selected directory completion, then complete
files in the directory.
p-ouellette
force-pushed
the
unicode-complete
branch
from
2f9ffdd
to
e044db1
Compare
p-ouellette
changed the title
|
@p-ouellette Thanks for the patch. |
|
Thank you for taking the time to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit log for details.