Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables spidev interfaces #181

Merged
merged 1 commit into from Apr 19, 2020
Merged

enables spidev interfaces #181

merged 1 commit into from Apr 19, 2020

Conversation

schubter
Copy link
Contributor

@schubter schubter commented Jun 2, 2019

by patching the dtb as closely as possible to raspbian, only difference
the gpio ports start with an offset of 458

@stapelberg
Copy link
Contributor

Thanks for this PR!

Would you mind also rebuilding the kernel and amending your changes to contain the updated vmlinuz file, too?

@schubter
Copy link
Contributor Author

schubter commented Jun 3, 2019

Hi,

i'll gladly add the updated dtb but honestly i'd rather not append the vmlinuz built by me. i am not sure you can verify that i've not tampered with the resulting binary or even used the code in the repo to build the image in the first place.

@stapelberg
Copy link
Contributor

Oh, I’ll rebuild myself and verify the checksum. It’s just nice to have the change represented in one git commit.

@schubter
Copy link
Contributor Author

schubter commented Jun 3, 2019

alright, that sounds fine. should have it updated in a few hours. my build box is slow ^^

@stapelberg
Copy link
Contributor

Thanks, this looks good! Can you squash your commits before I merge this please? We would like one logical commit per change in our git history.

@chlunde
Copy link

chlunde commented Apr 18, 2020

@schubter Cool, I had to rebase your commit (https://github.com/chlunde/kernel/commit/886bf5909ac0face5be509af4b697f683124a38f) but now I also got SPI to work with an e-ink display with periph.io@master.

If you rebase again maybe it can be merged, unless 5.6.6 is released and there's a new merge conflict :)

@stapelberg
Copy link
Contributor

Independent of merging this PR: can this change also be submitted for inclusion in the upstream Linux kernel?

@schubter
Copy link
Contributor Author

not sure, raspbian is handling this kind of enabling via overlays.

@stapelberg
Copy link
Contributor

not sure, raspbian is handling this kind of enabling via overlays.

Yeah, but upstream linux doesn’t, so it doesn’t really matter how raspbian solves this :)

@schubter
Copy link
Contributor Author

good point, let me see if I can work thru the requirements to get something added to the kernel

by patching the dtb as closely as possible to raspbian, only difference
the gpio ports start with an offset of 458
@schubter
Copy link
Contributor Author

Alright rebased. Thanks @chlunde

@stapelberg stapelberg merged commit f686f39 into gokrazy:master Apr 19, 2020
@stapelberg
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants