Cache HMAC object and fix memory leak #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
NewHMAC
so it reuses the sameEVP_MAC
object instead of fetching it every time.Doing so also fixed a memory leak: the object returned by
EVP_MAC_fetch
should have been freed usingEVP_MAC_free
. The new approach doesn't require freeing that object, as it is kept as a global variable to be reused later on.Thanks to caching,
NewHMAC
is now ~9% faster: