Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possible use-after-free issue in
evpHash.WriteString
and inevpHash.WriteByte
. They both passh.ctx
toEVP_DigestUpdate
without making sureh
is still alive until the cgo call ends, i.e. usingruntime.KeepAlive(h)
.If the garbage collector chimes in at the right time, it will collect
h
, calling it's finalizer, that free'sh.ctx
, likely producing an invalid access exception.Ported from microsoft/go-crypto-openssl#55.