New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello, I have two questions for you. #227

Closed

onntztzf opened this issue Aug 11, 2022 · 1 comment · Fixed by #274

onntztzf commented Aug 11, 2022

Hello, I have two questions for you.

Why do I Validate Claims first and Perform Validation later?
In line 70 of Parser. go, ValidationError.Errors is used XOR, but Inner is overridden directly. This causes the actual error causes in the Validate Claims to be lost. You could do this with Errors, but it's a little inconvenient. Why is it designed that way?

oxisto linked a pull request

that will close this issue

More consistent way of handling validation errors #274

Merged

Collaborator

oxisto commented Feb 21, 2023

Fixed by #234

oxisto closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment