Merge pull request #69 from bcho/fix/mysql-url-password-encode

prevent net/url encoding the user password
golang-migrate · Jun 29, 2018 · 78d696c · 78d696c
2 parents 18583d5 + 48a4062
commit 78d696c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/database/mysql/mysql.go b/database/mysql/mysql.go
@@ -90,6 +90,7 @@ func WithInstance(instance *sql.DB, config *Config) (database.Driver, error) {
 }
 
 func (m *Mysql) Open(url string) (database.Driver, error) {
+	url = strings.TrimPrefix(url, "mysql://")
 	purl, err := nurl.Parse(url)
 	if err != nil {
 		return nil, err
@@ -99,8 +100,7 @@ func (m *Mysql) Open(url string) (database.Driver, error) {
 	q.Set("multiStatements", "true")
 	purl.RawQuery = q.Encode()
 
-	db, err := sql.Open("mysql", strings.Replace(
-		migrate.FilterCustomQuery(purl).String(), "mysql://", "", 1))
+	db, err := sql.Open("mysql", migrate.FilterCustomQuery(purl).String())
 	if err != nil {
 		return nil, err
 	}