Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/satori/uuid has security issues #308

Closed
cbndr opened this issue Nov 26, 2019 · 4 comments
Closed

github.com/satori/uuid has security issues #308

cbndr opened this issue Nov 26, 2019 · 4 comments

Comments

@cbndr
Copy link

cbndr commented Nov 26, 2019

Describe the Bug
Current golang-migrate version uses the package github.com/satori/uuid, which has security issues and seems to be no longer maintained. There is a drop-in replacement github.com/gofrs/uuid by a team who forked satori/uuid, removed the issues and maintains the lib.

Steps to Reproduce
Check module dependencies.

Expected Behavior
Use github.com/gofrs/uuid (satori/uuid compatible interface) or google/uuid.

Migrate Version
v4.7.0

Go Version
go version go1.13 linux/amd64

@dhui
Copy link
Member

dhui commented Dec 16, 2019

Migrate doesn't have a direct dependency on github.com/satori/uuid
If you can identify the indirect dependency chain (go mod why and go mod why -m don't work for some reason...), I'd be happy update accordingly

@cbndr
Copy link
Author

cbndr commented Dec 16, 2019

Right, go mod why also doesn't work for me. If I do go mod graph | grep uuid, I get github.com/golang-migrate/migrate/v4@v4.7.0 github.com/satori/go.uuid@v1.2.0. Will try to find out where it comes from.

@thesoulless
Copy link

It's actually a Cockroachdb's dependancy:

# github.com/satori/go.uuid
github.com/golang-migrate/migrate/v4/database/cockroachdb
github.com/cockroachdb/cockroach-go/crdb
github.com/jackc/pgx
github.com/jackc/pgx.test
github.com/satori/go.uuid

So we can close this issue and open one on their repo.

@dhui dhui closed this as completed in 1de555b Mar 4, 2020
@dhui
Copy link
Member

dhui commented Mar 4, 2020

Thanks @thesoulless for the pointer! Looks like go mod why works better in Go 1.14

The issue is already fixed in cockroachdb I updated the driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants