-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for spanner #410
Comments
I've done some things similar to this in Circle, and I can see where the integration test code is happening. Looks like I'd use your docker testing framework for this part vs. the way the existing integration test is handled, right? |
The current spanner tests aren't run in CI since they're tagged as short. This change would involve using either using docker images or the in-memory emulator in the tests. The main advantage of using the docker image is that we can test against different versions of the spanner emulator which in theory, reflect the different versions of spanner. |
Fixed in master. We're using the in-memory emulator directly. |
Is your feature request related to a problem? Please describe.
The spanner db driver should have integration tests to prevent regressions
Describe the solution you'd like
Use the spanner emulator which is available with pre-built docker images
Describe alternatives you've considered
Additional context
N/A
The text was updated successfully, but these errors were encountered: